From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by kanga.kvack.org (Postfix) with ESMTP id 281BA6B0038 for ; Wed, 14 Sep 2016 12:37:25 -0400 (EDT) Received: by mail-pa0-f72.google.com with SMTP id fu12so37799825pac.1 for ; Wed, 14 Sep 2016 09:37:25 -0700 (PDT) Received: from mga01.intel.com (mga01.intel.com. [192.55.52.88]) by mx.google.com with ESMTPS id o6si5428217pan.251.2016.09.14.09.37.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 14 Sep 2016 09:37:23 -0700 (PDT) Subject: Re: [PATCH] memory-hotplug: Fix bad area access on dissolve_free_huge_pages() References: <1473755948-13215-1-git-send-email-rui.teng@linux.vnet.ibm.com> <57D83821.4090804@linux.intel.com> From: Dave Hansen Message-ID: <57D97CAF.7080005@linux.intel.com> Date: Wed, 14 Sep 2016 09:37:03 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rui Teng , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Naoya Horiguchi , Michal Hocko , "Kirill A . Shutemov" , Vlastimil Babka , Mike Kravetz , "Aneesh Kumar K . V" , Paul Gortmaker , Santhosh G On 09/14/2016 09:33 AM, Rui Teng wrote: > > How about return the size of page freed from dissolve_free_huge_page(), > and jump such step on pfn? That would be a nice improvement. But, as far as describing the initial problem, can you explain how the tail pages still ended up being PageHuge()? Seems like dissolving the huge page should have cleared that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760930AbcINQhZ (ORCPT ); Wed, 14 Sep 2016 12:37:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:4990 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbcINQhY (ORCPT ); Wed, 14 Sep 2016 12:37:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,334,1470726000"; d="scan'208";a="1055936028" Subject: Re: [PATCH] memory-hotplug: Fix bad area access on dissolve_free_huge_pages() To: Rui Teng , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1473755948-13215-1-git-send-email-rui.teng@linux.vnet.ibm.com> <57D83821.4090804@linux.intel.com> Cc: Andrew Morton , Naoya Horiguchi , Michal Hocko , "Kirill A . Shutemov" , Vlastimil Babka , Mike Kravetz , "Aneesh Kumar K . V" , Paul Gortmaker , Santhosh G From: Dave Hansen Message-ID: <57D97CAF.7080005@linux.intel.com> Date: Wed, 14 Sep 2016 09:37:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2016 09:33 AM, Rui Teng wrote: > > How about return the size of page freed from dissolve_free_huge_page(), > and jump such step on pfn? That would be a nice improvement. But, as far as describing the initial problem, can you explain how the tail pages still ended up being PageHuge()? Seems like dissolving the huge page should have cleared that.