From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757068AbcIPIh2 (ORCPT ); Fri, 16 Sep 2016 04:37:28 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:41732 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754678AbcIPIhV (ORCPT ); Fri, 16 Sep 2016 04:37:21 -0400 Subject: Re: [PATCH] phy: sun4i-usb: Fix build dependency To: Axel Lin References: <1473992148-8860-1-git-send-email-axel.lin@ingics.com> CC: Hans de Goede , Maxime Ripard , , "arnd@arndb.de" From: Kishon Vijay Abraham I Message-ID: <57DBAF31.4030604@ti.com> Date: Fri, 16 Sep 2016 14:07:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1473992148-8860-1-git-send-email-axel.lin@ingics.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Arnd Hi, On Friday 16 September 2016 07:45 AM, Axel Lin wrote: > of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below > build error. > > ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined! > scripts/Makefile.modpost:91: recipe for target '__modpost' failed > make[1]: *** [__modpost] Error 1 Arnd was trying to solve the same issue. Thanks Kishon > > Signed-off-by: Axel Lin > --- > drivers/phy/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index cc27c12..b65aba0 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -258,6 +258,8 @@ config PHY_SUN4I_USB > depends on RESET_CONTROLLER > depends on EXTCON > depends on POWER_SUPPLY > + depends on USB_SUPPORT > + select USB_COMMON > select GENERIC_PHY > help > Enable this to support the transceiver that is part of Allwinner >