From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Griffin <john.griffin@intel.com>
Subject: Re: [PATCH] crypto/qat: fix memzone creation to use a
 fixed size string
Date: Mon, 19 Sep 2016 11:12:15 +0100
Message-ID: <57DFB9FF.5090907@intel.com>
References: <1472725298-8455-1-git-send-email-john.griffin@intel.com>
 <20160905032356.GH30752@yliu-dev.sh.intel.com> <57D96D9E.8040301@intel.com>
 <20160918081643.GE23158@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, eoin.breen@intel.com, pablo.de.lara.guarch@intel.com
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id F11AF292D
 for <dev@dpdk.org>; Mon, 19 Sep 2016 12:12:40 +0200 (CEST)
In-Reply-To: <20160918081643.GE23158@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 18/09/16 09:16, Yuanhan Liu wrote:
> On Wed, Sep 14, 2016 at 04:32:46PM +0100, John Griffin wrote:
>> Hi Liu,
>> Comments embedded.
>>
>> Rgds,
>> John.
>>
>> On 05/09/16 04:23, Yuanhan Liu wrote:
>>> On Thu, Sep 01, 2016 at 11:21:38AM +0100, John Griffin wrote:
>>>> Remove the dependency on dev->driver->pci_drv.name when
>>>> creating the memzone for the qat hardware queues.
>>>> The pci_drv.name may grow too large for RTE_MEMZONE_NAMESIZE.
>>>
>>> Will the "may grow too large" cause any issues? If so, state it here. If
>>> not, marking this patch as a "fix" patch doesn't make sense to me then.
>> We discovered this when applying a future patch (2141c21966) and it exposed
>> this issue.
>> Problem is we create a memzone per hardware queue pair and if the memzone
>> name is too large, then this code will not produce a unique
>> name and two qps will end using the same memzone.
>
> Thanks for the info, and I think you should put it in the commit log: it
> helps people to really know what might go wrong without this fix.
>
> 	--yliu
>
No problem. Yes will add to the v2.

Rgds,
John.