From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932282AbcISOsZ (ORCPT ); Mon, 19 Sep 2016 10:48:25 -0400 Received: from mail-sn1nam01on0116.outbound.protection.outlook.com ([104.47.32.116]:54638 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932238AbcISOsU (ORCPT ); Mon, 19 Sep 2016 10:48:20 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <57DFFAAC.4010108@hpe.com> Date: Mon, 19 Sep 2016 10:48:12 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Matt Fleming CC: Linus Torvalds , "Theodore Ts'o" , Arnd Bergmann , Greg Kroah-Hartman , Linux Kernel Mailing List , Scott J Norton , Douglas Hatch , Borislav Petkov Subject: Re: [PATCH] random: Fix kernel panic due to system_wq use before init References: <1473879781-23819-1-git-send-email-Waiman.Long@hpe.com> <57D9A1A9.8050506@hpe.com> <57DF56D4.50304@hpe.com> <20160919124325.GE2892@codeblueprint.co.uk> In-Reply-To: <20160919124325.GE2892@codeblueprint.co.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.111] X-ClientProxiedBy: BN6PR15CA0001.namprd15.prod.outlook.com (10.172.204.139) To CS1PR84MB0312.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.30) X-MS-Office365-Filtering-Correlation-Id: ead9b803-128a-46a7-f3ec-08d3e09bfe78 X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;2:A2Z9WOrckPZyMnv6Hf4cR6f4Yxz0CWwMgRRnPPGkzc0Zo6gKW6N/kS/9JEmtfbBSiimQn9MjStK/GFMJHp/PoN6dMl77vTigml0BPGdL2TFKa0TwfS7Y0/pUURbNuG0EoC+d6huxpirSCQ0aRQZ+hWn7ArO6pCcsw+nkjt9nb16Ii1elohPH9XN7qVlooA3o;3:1LSrSqWpStj1VPo9Jr+yNM40PuCDtrqKias93hXu0XqChoCa26kkcfolfaqLchhL+AMlVAyaSj+RDeyyHHldn4mstP33s7a7eUYwlwknw2uy8TzqouETDKaoM50PTraL X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0312; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;25:KTyPBSLcJVVJgK3xK30ufvTjNCXGBAkp1jn7jbjR/b05UwMpwX8S8w8jC7UvcKip+kVIsMZpA3my4QTH+imC/UKI90xPvQpVS8pO7fgrmue8iz2wj2rLIk7J2cOmezF/FU2JzyGT2aIhdn6iSBvJ+sDSClPzvZPj4Y4puuLY0o3MT/kr9nMWJHzkDa3ARbEaQdgt7f85ofsqKZxbeUebzvttU/WrGZoYiFbQZwy4R8A65iBwtHw1X70NnIBX9ohE484HgR6uoafK8ck7dYT0Gz4F+jbBJB/BfNP8h584LO0fzftxzVPG0JAqiZaEoeMzm5jUJdD4wW/EsmQOVt6AIWc0T57RNTkVkMKtKy9VUu75zsvkXXvdkOhoC2DkMIOalKvCkts7pYwNtoo/CL7ZzwUAwJIuOvp5surAD+laX9zI98g6sAlHZLcMNI2BDVIkqEIfZ/WH1eLZtUeJv5dRh/xFC3WQvhz/FGXO3hbZFZ+WRHH53vgbKAAsM614PXOjz5Le3sMtMhoUcDYrp8ZTaMWRhrSmFLSX2u6EPDJkte2X9HlZ92xdGA6pQFUHLXh9SXRVA09Y5CTUkPBUWhvcTtTX78iSrq4zM0fzMyIMdIwEfRWSosPgksGXpE/4UH3e9RjO9I2iocbuiT56tuYY0D4NAZ+DCuFtjQEvcgg3LwRrxMz2hNr8hyxLsrkmXodsNfup1S4pX3UthrdR0APDkqAcvy2NqGcQ2WmgwvMfIvg= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;31:EJ8T5WU0iJ56m2nwYNNitMapKDJ9+jVf5jU4gvwRyPvaX8nIcjlwn6Hhhi+y/IJba4Y0zDEiGJeOv29FgeIUCHqWF3bxQA4BzYHncrLE+d+ODCZ0iMFtbojdI0U7ce+ZdtUIFGQah9+asaeEKDpUGNVDsjBMG7RYKFnNBmWvS+qWFwEcVQjl2rZt38igiJcFzdrxYxo/e5BODuZ/ARN1fN7gLIR95mcJyF/HNRABu/8=;20:+jqEz022ZRfAI4tnF7uZDRsVOby+u3sARxa0qqoY9YjF9EpDM99xZDEPDMpZadmOWKcHKWRcNjgHVzwAVcV+eiBz39gHw1Xdiv/vHI3qUQZHbQ8m9f+A+cNMGKKKVdYwOED1oYXnu7xokLkot65Bte0+QVBccLr1LOe1i3fl2QG/Vib/eRpQ/qKTR9k4pIJT0VrsxrnDXtF8mJY/RtCn/kb+QjkX+coCPeFBYShnmCqnxHaGIP3T5Qk9C/ZLPCQQlrepH9AuSaTQBzM2Na5Hw5MGBrC9760OL5VJ2PK1o8wmSTP3R3rPhfED7r7NdgEdiGV/MShCTQ7jF/0nsUth3pmEWpyAdLWneSW91yVqyQniNZtdKmNXQvvV+wpHrufPXqC0j+ApCTNXjItxKfLXwS7MGn4Q27nQAgt6v0BumUIbLNIV+3kqrPtJlGpUM+Q9cMJq2NhQ19MOUOtzMRPUPN7YV9YdjMzSJVh1L7dK0d6gzbVfS/JW5mT7+tQwzr1y X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(227479698468861); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CS1PR84MB0312;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0312; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;4:k1pWCq7t8a/W40KjdFJyfjuNdrRt+inmY5gMoVECgE873DxAbnldkArHUmWqCBT5l7Fo1ML1iZT1Xs3emNsIrELvxHjtKwUnMEbWs0XH8QBqFZynFg8J1/FyIE2CuFPfeo/qoPu6xIviR8vyXfyh0RvlNyUYNnn/SZZSEqU9tu0DeCpAK+bG+hgyxdA8woKMR9mZ+8FzkP1s44e4SMfKdj1ORBsSCY62SqsSVCvYX6b9Khbf+3CLKYkCejzzlHcCzhgoQ81fOEcCzo42CVUEicjgg4ZMEe6rVGS6zIxbRXoYKccBW7LmTysPPyvYGAWJIz4JY+BjolBTEWvRtLEQtojfu4s0Mqtf8+CkNfwJLB7MRvFk8SsWGPYFd7FKliqg8/k9Nhyu35AGrvfdP8vBxe02qwadRLB+kAFeUjAc8+zl00wcQWtETN1KAtrQ7wOp X-Forefront-PRVS: 0070A8666B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(24454002)(377454003)(189002)(42186005)(106356001)(54356999)(76176999)(50986999)(65816999)(87266999)(97736004)(36756003)(2950100001)(77096005)(2906002)(105586002)(101416001)(59896002)(65806001)(117156001)(47776003)(68736007)(65956001)(305945005)(93886004)(7736002)(7846002)(66066001)(4326007)(189998001)(6116002)(586003)(3846002)(19580395003)(4001350100001)(230700001)(81166006)(83506001)(23756003)(80316001)(33656002)(8676002)(19580405001)(81156014)(64126003)(5660300001)(86362001)(92566002)(50466002)(110136003);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0312;H:[192.168.142.208];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CS1PR84MB0312;23:QXgKCt8tcn/2ugUA69Ltl7Mwh43obf0BNQzyyDq?= =?iso-8859-1?Q?N3tDlsoSmEMS8iH6MSsO5q0t9XAVMwuV8BtWConyZfn8pgwq2Aj0FPzlA0?= =?iso-8859-1?Q?zCGWkqNJv1UYyBs5cn161LOhGmunr1XK7lnRPOT354cRQMQuoylpvC++ds?= =?iso-8859-1?Q?KDoXlhoaegTEaB6jv+cIZz179HS8fZW04ZtRFRQ6qlnZOKJBjuCnYboD87?= =?iso-8859-1?Q?5xGdFI46euo569hkVSyIwSyiS0lhwKptiYpkyQN/q36lTwInY/zkJP8WGE?= =?iso-8859-1?Q?/KmAlqm8w0lPNWGAhBkxAT37Ep2MKc/0AghP8t1ui44RDH+lNHNcaWkY1r?= =?iso-8859-1?Q?4yCW3CpQ/TADvNFVwNbsRGVtDx9dETdv8Qqj2nYjwRgEv2HDiCvU4J7tN+?= =?iso-8859-1?Q?O4dpaaOzLEX+LfUbljpWTYAtuJ+4kQ2D+ysXn4UUT4HHepxQhA3+U0+Wog?= =?iso-8859-1?Q?6UGJuroTyEOo7g7WNsX6MTHd2pVA+sPFOG5FmKJmae4n4WNBMGNTHBWr18?= =?iso-8859-1?Q?YNDZCbIs3Fd/9TyYDp+DuKav08mQFEcKRm+HrkPfHzTj1jC2f4lsVd6L6Y?= =?iso-8859-1?Q?n1mGTufXouXbtXeHUgbTqiA2JdvfPP/vS8wVubOi+7Nnbn4k3khpo2C7m0?= =?iso-8859-1?Q?iDtJ28+IywO5o8pONOIM96uRYr3oWXgNFwwLn7hZdK/9NQpBW1ayxToI5I?= =?iso-8859-1?Q?9ItBNEtL5m7LyA2z1yRteXggHkDq9sMZvsbo3qtat+ng0daSIvI7VumwNY?= =?iso-8859-1?Q?pbK7fEJ4b3movK6rnJ5E/SBQS2V6nS3DE6yjLl7GzeDhsKeeH8vLZxoHQ6?= =?iso-8859-1?Q?zmTzlpRwaem82FKte6s5APGhbIm7MNCuK3YTeZyCzX+2UucxMQy2+9sNGF?= =?iso-8859-1?Q?5rPvggjM7jVhStKQt+/nzjzou3N97d+Wbg3pvYzy5hvuWT0ByXtTMWvldS?= =?iso-8859-1?Q?y4SaxpPtAlP0352+RtT41VwZXeGYySDvUErjs+B32D9TdD5dQd/VKyJwnC?= =?iso-8859-1?Q?IfvlOTR+PtQFH+j94i12/lWF7dPpO2Tg8DY2sLSrACNECYhIc8OYCIT+sm?= =?iso-8859-1?Q?twV5zAtevNz9lbsb6EBcgo+PflBHpXo8cqceeGaYA3Rs4kdzp8eAACFzp6?= =?iso-8859-1?Q?vrwxGpfPX+y2nzc2Mq1Ydt5VQkEHZRxFy1NsL0lKDpBUEVcf9RA3Kmj2d+?= =?iso-8859-1?Q?ikGNXzYl+A4PzvlZSbb7Wk5SdgbLXdPOqFCQxTFLgEYjaPYBUSFbuOjvwT?= =?iso-8859-1?Q?YtHU4+zRkx0Rx+EF6BHd0lCzJVcDRDW7EQBW83iESLk6d+JOi/FDQVordf?= =?iso-8859-1?Q?wKuZWxcWRjEHgkbhUJWHAnXyK9fLH/SjzM62oNx0+zUzT0FOBv+9CXz3Bq?= =?iso-8859-1?Q?ehC0VuDOHt/sXK4NLHNEopGtDtBZD+aS6sfHvgrSkYd7AFqHLAQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;6:P8KfabWaCVIgJh+0nuvdY5dzxj1G7IqqJ7j2OISVV7qbH5tvyWz94P+QX1BnaC6ObYm5tuRj/W6soZbG5u6AeWnQB/Ip9Gf3LK6o88HqifFhqEfskVRAQnx+NcCkO4lbwQPCBx7Jn6KWhDnMhGKw3SUkuDVHFxM2+kNlPwLwe6Lf1bjm/HfudFCfFkdmabELureOt+ABAr1Ve0QngX1xLsBjIgdVOogzZOc3IWuUelDJ/+zMhM5Rn8J9f8pinuQO3OHofFZhkRCDNQgEFJWB7xl7PoOMgkw37YCgfuu0DGcaNafY/L1DFZMrNaksoxeYf7Z6kY1U0AQEQsRCHsq8GA==;5:yexcDYGZSPww1aYqE4bx59icDHTIxZJxJ8xsJxJaSh9wbKYP1+G4ovHS1XIUMdtGMGizU7k4SoqpospvcrjlQxZ1t5ZcE7ujXc6bNwKtdph8EGyEiF/YJjALelFo75zVdN+o7WbJ3d2gUx54mlE4jA==;24:26VYhr0P7Gn0L0mc583Ohj4UZ7D3/BWAcNgUQ4B7WTR9+breMWJj8pH7i3GfX2xBiTNtvcV2xoDdXF9bq4Tavm0iv6+rFvWIkVZy2oA1UCY=;7:6GScPUjZvfBqGr9IXNL7S+9suWuSIG2javm+u+AjfDuuFZ+auTDVoKVnvJdZQBLiUyxi16M7oYXXzXHGW5ZbLZjVtgXTv/ohiwd7s83acy8y9XuxVYMCa+b67S7tR7Tk1rOfpk/Kf2Ww85LJjwqKmwZrYaukXAiuaMSMgms8fzZEcvjVSOIzE7VRnKSbMG8GfkyPhCoVb8MNbv3roXk+WJJvfrRT+vYrb5rhfU1dyFCRgIyjvQ/yYS52AMFUJ60IqX/AQ8JX2FjhJz5asynOLVWNPqsTQim9vhOe+9+FFsuSSXjDDFluAO4jJQS8uWrj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 14:48:17.4016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/19/2016 08:43 AM, Matt Fleming wrote: > On Sun, 18 Sep, at 11:09:08PM, Waiman Long wrote: >> On 09/14/2016 03:19 PM, Linus Torvalds wrote: >>> On Wed, Sep 14, 2016 at 12:14 PM, Waiman Long wrote: >>>> In the stack backtrace above, the kernel hadn't even reached SMP boot after >>>> about 50s. That was extremely slow. I tried the 4.7.3 kernel and it booted >>>> up fine. So I suspect that there may be too many interrupts going on and it >>>> consumes most of the CPU cycles. The prime suspect is the random driver, I >>>> think. >>> Any chance of bisecting it at least partially? The random driver >>> doesn't do interrupts itself, it just gets called by other drivers >>> doing intterrupts. So if there are too many of them, that would be >>> something else.. >>> >>> Linus >> I have finally finished bisecting the problem. I was wrong in saying that >> the 4.7.3 kernel had no problem. It did have. There were some slight >> differences between the 4.8 and 4.7 kernel config files that I used. After >> some further testing, it was found that the bootup problem only happened >> when the following kernel config option was defined: >> >> CONFIG_EFI_MIXED=y > > Could you try this patch? It won't be the final version, because it > doesn't address the root cause of the crash, which looks like page > table corruption of some kind, but it should at least confirm that > this is the buggy code, > > --- > > diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c > index 677e29e29473..8dd3784eb075 100644 > --- a/arch/x86/platform/efi/efi_64.c > +++ b/arch/x86/platform/efi/efi_64.c > @@ -245,7 +245,7 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages) > * text and allocate a new stack because we can't rely on the > * stack pointer being< 4GB. > */ > - if (!IS_ENABLED(CONFIG_EFI_MIXED)) > + if (!IS_ENABLED(CONFIG_EFI_MIXED) || efi_is_native()) > return 0; > > /* With this patch applied, I am able to successfully boot both the 16-socket 12-TB and 8-socket 6TB configurations without problem. Tested-by: Waiman Long