From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count Date: Tue, 20 Sep 2016 18:34:28 +0900 Message-ID: <57E102A4.9050805@samsung.com> References: <1474361863-2319-1-git-send-email-axel.lin@ingics.com> <1474361863-2319-2-git-send-email-axel.lin@ingics.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:59139 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbcITJeb (ORCPT ); Tue, 20 Sep 2016 05:34:31 -0400 In-reply-to: <1474361863-2319-2-git-send-email-axel.lin@ingics.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Axel Lin , "Rafael J . Wysocki" Cc: MyungJoo Ham , Kyungmin Park , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Hi, On 2016년 09월 20일 17:57, Axel Lin wrote: > This is done by devfreq_event_get_event() so remove the redundant code in > exynos_nocp_get_event(). > > Signed-off-by: Axel Lin > --- > drivers/devfreq/event/exynos-nocp.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c > index a584140..49e712a 100644 > --- a/drivers/devfreq/event/exynos-nocp.c > +++ b/drivers/devfreq/event/exynos-nocp.c > @@ -176,9 +176,6 @@ static int exynos_nocp_get_event(struct devfreq_event_dev *edev, > return 0; > > out: > - edata->load_count = 0; > - edata->total_count = 0; > - > dev_err(nocp->dev, "Failed to read the counter of NoC probe device\n"); > > return ret; > As you said, devfreq_event_get_event() initializes both load_count and total_count before calling edev->desc->ops->get_event(). Looks good to me. Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi