All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: Flora Cui <Flora.Cui-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset
Date: Tue, 20 Sep 2016 18:19:33 +0800	[thread overview]
Message-ID: <57E10D35.5040006@amd.com> (raw)
In-Reply-To: <1474362552-9062-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>



On 2016年09月20日 17:09, Flora Cui wrote:
> Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4d87609
> Signed-off-by: Flora Cui <Flora.Cui@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
> index 262e872..b266cf7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
> @@ -128,8 +128,8 @@ int amdgpu_gtt_mgr_alloc(struct ttm_mem_type_manager *man,
>   
>   	if (!r) {
>   		mem->start = node->start;
> -		tbo->offset = (tbo->mem.start << PAGE_SHIFT) +
> -		    tbo->bdev->man[tbo->mem.mem_type].gpu_offset;
> +		tbo->offset = (mem->start << PAGE_SHIFT) +
> +		    tbo->bdev->man[mem->mem_type].gpu_offset;
mem->mem_type seems not set yet as well if I am correct.
IIRC, I feel it's better that tbo->offset is set out of this function 
after get_node successfully.

Regards,
David Zhou

>   	}
>   
>   	return r;

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2016-09-20 10:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20  9:09 [PATCH] drm/amdgpu: fix gtt_mgr bo's offset Flora Cui
     [not found] ` <1474362552-9062-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
2016-09-20 10:19   ` zhoucm1 [this message]
     [not found]     ` <57E10D35.5040006-5C7GfCeVMHo@public.gmane.org>
2016-09-20 10:41       ` Flora Cui
2016-09-20 11:02         ` Christian König
     [not found]           ` <b4bb5cc9-39de-aff6-ec12-2d97d0cc9fcd-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-09-20 11:16             ` Flora Cui
2016-09-20 11:40               ` Christian König
     [not found]                 ` <ec255145-4ee3-caab-bfc5-644f4afba6ad-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-09-21  1:54                   ` zhoucm1
     [not found]                     ` <57E1E83C.5070107-5C7GfCeVMHo@public.gmane.org>
2016-09-21  3:22                       ` Flora Cui
2016-09-20 11:24             ` Flora Cui
2016-09-20 10:43       ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E10D35.5040006@amd.com \
    --to=david1.zhou-5c7gfcevmho@public.gmane.org \
    --cc=Flora.Cui-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.