From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] rk3288: config change for enable dram capacity auto-detect.
Date: Wed, 21 Sep 2016 11:00:09 +0800 [thread overview]
Message-ID: <57E1F7B9.3060106@rock-chips.com> (raw)
In-Reply-To: <CABCGj3beTsxjetB1S-F1KDsw0+keLt=WQ7MZUMnX8+3y-w9f6w@mail.gmail.com>
Hi Sandy,
On 09/20/2016 09:21 PM, Sandy Patterson wrote:
> You're probably going to need to change this around now that the
> Kconfig stuff has been applied to master. Suggest following patch instead:
I didn't enable the BACK_TO_BROM for all of rk3288 board, because boards
like firefly and chromebook-jerry have enough space without this macro,
and I'm not able to test them, so I only change for those boards which
must enable this macro.
What's you opinion for firefly-rk3288 and chrome-jerry?
Thanks,
- Kever
>
> diff --git a/arch/arm/mach-rockchip/Kconfig
> b/arch/arm/mach-rockchip/Kconfig
> index 1aac3c8..dc471d6 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -36,7 +36,7 @@ config ROCKCHIP_RK3399
> config ROCKCHIP_SPL_BACK_TO_BROM
> bool "SPL returns to bootrom"
> - default y if ROCKCHIP_RK3036
> + default y if ROCKCHIP_RK3036 || ROCKCHIP_RK3288
> help
> Rockchip SoCs have ability to load SPL & U-Boot binary. If
> enabled,
> SPL will return to the boot rom, which will then load the
> U-Boot
> diff --git a/arch/arm/mach-rockchip/rk3288/Kconfig
> b/arch/arm/mach-rockchip/rk3288/Kconfig
> index 94863a9..1425ce1 100644
> --- a/arch/arm/mach-rockchip/rk3288/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3288/Kconfig
> @@ -82,7 +82,7 @@ config SPL_LIBGENERIC_SUPPORT
> default y
> config SPL_MMC_SUPPORT
> - default y
> + default y if !ROCKCHIP_SPL_BACK_TO_BROM
> config SPL_SERIAL_SUPPORT
> default y
>
>
> On Mon, Sep 19, 2016 at 11:28 PM, Kever Yang
> <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>> wrote:
>
> Enable ROCKCHIP_SPL_BACK_TO_BROM and disable CONFIG_SPL_MMC_SUPPORT
> to save memory in order to enable add source code for dram capacity
> auto-detect.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com
> <mailto:kever.yang@rock-chips.com>>
> ---
>
> Changes in v2: None
>
> include/configs/evb_rk3288.h | 3 +--
> include/configs/fennec_rk3288.h | 3 +--
> include/configs/miniarm_rk3288.h | 3 +--
> include/configs/popmetal_rk3288.h | 3 +--
> 4 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/include/configs/evb_rk3288.h
> b/include/configs/evb_rk3288.h
> index 342557f..9f32184 100644
> --- a/include/configs/evb_rk3288.h
> +++ b/include/configs/evb_rk3288.h
> @@ -7,11 +7,10 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> +#define CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
> #define ROCKCHIP_DEVICE_SETTINGS
> #include <configs/rk3288_common.h>
>
> -#define CONFIG_SPL_MMC_SUPPORT
> -
> #define CONFIG_ENV_IS_IN_MMC
> #define CONFIG_SYS_MMC_ENV_DEV 1
> /* SPL @ 32k for ~36k
> diff --git a/include/configs/fennec_rk3288.h
> b/include/configs/fennec_rk3288.h
> index 342557f..9f32184 100644
> --- a/include/configs/fennec_rk3288.h
> +++ b/include/configs/fennec_rk3288.h
> @@ -7,11 +7,10 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> +#define CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
> #define ROCKCHIP_DEVICE_SETTINGS
> #include <configs/rk3288_common.h>
>
> -#define CONFIG_SPL_MMC_SUPPORT
> -
> #define CONFIG_ENV_IS_IN_MMC
> #define CONFIG_SYS_MMC_ENV_DEV 1
> /* SPL @ 32k for ~36k
> diff --git a/include/configs/miniarm_rk3288.h
> b/include/configs/miniarm_rk3288.h
> index 342557f..9f32184 100644
> --- a/include/configs/miniarm_rk3288.h
> +++ b/include/configs/miniarm_rk3288.h
> @@ -7,11 +7,10 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> +#define CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
> #define ROCKCHIP_DEVICE_SETTINGS
> #include <configs/rk3288_common.h>
>
> -#define CONFIG_SPL_MMC_SUPPORT
> -
> #define CONFIG_ENV_IS_IN_MMC
> #define CONFIG_SYS_MMC_ENV_DEV 1
> /* SPL @ 32k for ~36k
> diff --git a/include/configs/popmetal_rk3288.h
> b/include/configs/popmetal_rk3288.h
> index 342557f..9f32184 100644
> --- a/include/configs/popmetal_rk3288.h
> +++ b/include/configs/popmetal_rk3288.h
> @@ -7,11 +7,10 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> +#define CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
> #define ROCKCHIP_DEVICE_SETTINGS
> #include <configs/rk3288_common.h>
>
> -#define CONFIG_SPL_MMC_SUPPORT
> -
> #define CONFIG_ENV_IS_IN_MMC
> #define CONFIG_SYS_MMC_ENV_DEV 1
> /* SPL @ 32k for ~36k
> --
> 1.9.1
>
>
next prev parent reply other threads:[~2016-09-21 3:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 3:28 [U-Boot] [PATCH v2 0/3] Add sdram capacity auto detect for rk3288 Kever Yang
2016-09-20 3:28 ` [U-Boot] [PATCH v2 1/3] rk3288: config change for enable dram capacity auto-detect Kever Yang
2016-09-20 13:21 ` Sandy Patterson
2016-09-21 3:00 ` Kever Yang [this message]
2016-09-21 11:53 ` Sandy Patterson
2016-09-22 2:10 ` Kever Yang
2016-09-20 3:28 ` [U-Boot] [PATCH v2 2/3] rk3288: sdram: auto-detect the capacity Kever Yang
2016-09-23 2:53 ` Simon Glass
2016-10-07 9:14 ` Kever Yang
2016-10-06 0:28 ` Vagrant Cascadian
2016-09-20 3:28 ` [U-Boot] [PATCH v2 3/3] dts: rk3288: remove node in dmc which not need anymore Kever Yang
2016-09-23 2:58 ` Simon Glass
2016-10-06 0:28 ` Vagrant Cascadian
2016-09-20 15:04 ` [U-Boot] [PATCH v2 0/3] Add sdram capacity auto detect for rk3288 Sandy Patterson
2016-09-21 2:56 ` Kever Yang
2016-09-21 12:41 ` Sandy Patterson
2016-09-22 2:15 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E1F7B9.3060106@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.