From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Wed, 21 Sep 2016 09:36:27 +0530 Subject: [PATCH] phy: meson-usb2: Fix build dependency In-Reply-To: References: <1473991635-27973-1-git-send-email-axel.lin@ingics.com> Message-ID: <57E20743.3030408@ti.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote: > Martin Blumenstingl writes: > >> Hi Axel, >> >> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin wrote: >>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below >>> build error: >>> >>> drivers/built-in.o: In function `phy_meson_usb2_probe': >>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy' >>> Makefile:961: recipe for target 'vmlinux' failed >>> make: *** [vmlinux] Error 1 >>> >>> Signed-off-by: Axel Lin >>> --- >>> drivers/phy/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >>> index 6ad87ec..cc27c12 100644 >>> --- a/drivers/phy/Kconfig >>> +++ b/drivers/phy/Kconfig >>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2 >>> tristate "Meson USB2 PHY driver" >>> default ARCH_MESON >>> depends on OF && (ARCH_MESON || COMPILE_TEST) >>> + depends on USB_SUPPORT >>> + select USB_COMMON >>> select GENERIC_PHY >>> help >>> Enable this to support the Meson USB2 PHYs found in Meson8b >>> -- >>> 2.7.4 >>> >> thanks for this patch! >> >> How do we handle patches for drivers which will (unfortunately) not >> land in the linux 4.8 - should I integrate that into v3 of the patch >> (which I'll have to send anyways) or do we keep them separate? >> Maybe Kishon and/or Kevin can share their opinion on this. Since you are anyways planning to send v3, merge this patch too. Thanks Kishon > > It's up to Kishon if he wants a v3, or if he can fold in the fix > himself. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752240AbcIUEHB (ORCPT ); Wed, 21 Sep 2016 00:07:01 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:34529 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbcIUEHA (ORCPT ); Wed, 21 Sep 2016 00:07:00 -0400 Subject: Re: [PATCH] phy: meson-usb2: Fix build dependency To: Kevin Hilman , Martin Blumenstingl References: <1473991635-27973-1-git-send-email-axel.lin@ingics.com> CC: Axel Lin , Jerome Brunet , , From: Kishon Vijay Abraham I Message-ID: <57E20743.3030408@ti.com> Date: Wed, 21 Sep 2016 09:36:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote: > Martin Blumenstingl writes: > >> Hi Axel, >> >> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin wrote: >>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below >>> build error: >>> >>> drivers/built-in.o: In function `phy_meson_usb2_probe': >>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy' >>> Makefile:961: recipe for target 'vmlinux' failed >>> make: *** [vmlinux] Error 1 >>> >>> Signed-off-by: Axel Lin >>> --- >>> drivers/phy/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >>> index 6ad87ec..cc27c12 100644 >>> --- a/drivers/phy/Kconfig >>> +++ b/drivers/phy/Kconfig >>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2 >>> tristate "Meson USB2 PHY driver" >>> default ARCH_MESON >>> depends on OF && (ARCH_MESON || COMPILE_TEST) >>> + depends on USB_SUPPORT >>> + select USB_COMMON >>> select GENERIC_PHY >>> help >>> Enable this to support the Meson USB2 PHYs found in Meson8b >>> -- >>> 2.7.4 >>> >> thanks for this patch! >> >> How do we handle patches for drivers which will (unfortunately) not >> land in the linux 4.8 - should I integrate that into v3 of the patch >> (which I'll have to send anyways) or do we keep them separate? >> Maybe Kishon and/or Kevin can share their opinion on this. Since you are anyways planning to send v3, merge this patch too. Thanks Kishon > > It's up to Kishon if he wants a v3, or if he can fold in the fix > himself.