All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
	Richard Weinberger <richard@nod.at>,
	Sebastian Frias <sf84@laposte.net>,
	Jean-Baptiste Lescher <jblescher@gmail.com>,
	Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
	Mason <slash.tmp@free.fr>
Subject: Re: [PATCH v5] mtd: nand: tango: import driver for tango chips
Date: Wed, 21 Sep 2016 18:45:53 +0200	[thread overview]
Message-ID: <57E2B941.5010301@sigmadesigns.com> (raw)
In-Reply-To: <57DFE444.3000003@sigmadesigns.com>

On 19/09/2016 15:12, Marc Gonzalez wrote:

> +static int chip_init(struct device *dev, struct device_node *np, int kHz)
> +{
> +	int err;
> +	u32 cs, ecc_bits;
> +	struct nand_ecc_ctrl *ecc;
> +	struct tango_nfc *nfc = dev_get_drvdata(dev);
> +	struct tango_chip *p = devm_kzalloc(dev, sizeof(*p), GFP_KERNEL);

As pointed out by Boris on IRC, every chip needs a pointer back
to the parent device.

	p->chip.mtd.dev.parent = dev;

http://lxr.free-electrons.com/source/drivers/mtd/nand/sunxi_nand.c#L1729

      parent reply	other threads:[~2016-09-21 16:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 10:02 [PATCH v1] mtd: nand: tango: import driver for tango controller Marc Gonzalez
2016-09-05  7:14 ` Boris Brezillon
2016-09-05 10:18   ` Mason
2016-09-05 11:15     ` Boris Brezillon
2016-09-08 15:55       ` [PATCH v2] mtd: nand: tango: import driver for tango chips Marc Gonzalez
2016-09-08 16:37         ` Marc Gonzalez
2016-09-09 16:13           ` [PATCH v3] " Marc Gonzalez
2016-09-11 12:50             ` Mason
2016-09-12 19:08               ` Boris Brezillon
2016-09-19 13:12                 ` [PATCH v5] " Marc Gonzalez
2016-09-19 15:57                   ` Marc Gonzalez
2016-09-19 17:06                   ` Boris Brezillon
2016-09-19 22:37                     ` Mason
2016-09-20  7:24                       ` Boris Brezillon
2016-09-20  7:39                         ` Artem Bityutskiy
2016-09-20  7:57                           ` Richard Weinberger
2016-09-21 16:45                   ` Marc Gonzalez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E2B941.5010301@sigmadesigns.com \
    --to=marc_gonzalez@sigmadesigns.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=jblescher@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=sf84@laposte.net \
    --cc=slash.tmp@free.fr \
    --cc=thibaud_cornic@sigmadesigns.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.