From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH] dbus: Handle optional properties in PropertiesChanged
Date: Wed, 21 Sep 2016 16:53:58 -0500 [thread overview]
Message-ID: <57E30176.7090401@gmail.com> (raw)
In-Reply-To: <1474476105-10906-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Hi Andrew,
On 09/21/2016 11:41 AM, Andrew Zaborowski wrote:
> Handle property getter returning an error when building the
> PropertiesChanged signal instead of returning NULL. This is important
> because the signal may include multiple properties and if one getter
> fails other properties should still be included. One options is to only
> error out if all getters fail, another is to add them to the invalidated
> properties list of the signal. The latter seems to be the right thing
> to do for optional properties that may appear and disappear.
> ---
> ell/dbus-service.c | 26 +++++++++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2016-09-21 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 16:41 [PATCH] dbus: Handle optional properties in PropertiesChanged Andrew Zaborowski
2016-09-21 21:53 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E30176.7090401@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.