All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Axel Lin <axel.lin@ingics.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: exynos-ppmu: ppmu_events array should not be NULL terminated
Date: Thu, 22 Sep 2016 15:26:26 +0900	[thread overview]
Message-ID: <57E37992.2030500@samsung.com> (raw)
In-Reply-To: <1474417840-7999-1-git-send-email-axel.lin@ingics.com>

Hello,

On 2016년 09월 21일 09:30, Axel Lin wrote:
> The rest of the code uses ARRAY_SIZE to count the number of entries in
> ppmu_events array. The NULL terminated entry makes ARRAY_SIZE return
> off-by-one value.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/devfreq/event/exynos-ppmu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index f55cf0e..c9ffaf0 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -90,8 +90,6 @@ struct __exynos_ppmu_events {
>  	PPMU_EVENT(d1-cpu),
>  	PPMU_EVENT(d1-general),
>  	PPMU_EVENT(d1-rt),
> -
> -	{ /* sentinel */ },
>  };
>  
>  static int exynos_ppmu_find_ppmu_id(struct devfreq_event_dev *edev)
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi

  reply	other threads:[~2016-09-22  6:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160921003108epcas1p13c13f6dbfbcf86c22d88e33606e8fc97@epcas1p1.samsung.com>
2016-09-21  0:30 ` [PATCH] PM / devfreq: exynos-ppmu: ppmu_events array should not be NULL terminated Axel Lin
2016-09-22  6:26   ` Chanwoo Choi [this message]
2016-09-30 14:06     ` MyungJoo Ham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E37992.2030500@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=axel.lin@ingics.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.