From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Wouter Verhelst <w@uter.be>, Eric Blake <eblake@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>,
"nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
Kevin Wolf <kwolf@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"Stefan stefanha@redhat. com" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] write_zeroes/trim on the whole disk
Date: Sat, 24 Sep 2016 19:42:05 +0300 [thread overview]
Message-ID: <57E6ACDD.7080205@virtuozzo.com> (raw)
In-Reply-To: <FD5348CE-88CA-4833-AB84-90D04058A9AF@alex.org.uk>
On 24.09.2016 19:31, Alex Bligh wrote:
>> On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
>>
>> Note: if disk size is not aligned to X we will have to send request larger than the disk size to clear the whole disk.
> If you look at the block size extension, the size of the disk must be an exact multiple of the minimum block size. So that would work.
>
But there is no guarantee that disk_size/block_size < INT_MAX.. May be,
additional option, specifying the shift would be better. With convention
that if offset+length exceeds disk size, length should be recalculated
as disk_size-offset.
--
Best regards,
Vladimir
next prev parent reply other threads:[~2016-09-24 16:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 18:32 [Qemu-devel] write_zeroes/trim on the whole disk Vladimir Sementsov-Ogievskiy
2016-09-23 19:00 ` Eric Blake
2016-09-23 21:21 ` Wouter Verhelst
2016-09-24 7:54 ` Denis V. Lunev
2016-09-24 10:31 ` [Qemu-devel] [Nbd] " Alex Bligh
2016-09-24 22:07 ` Wouter Verhelst
2016-09-24 12:06 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy
2016-09-24 12:27 ` Vladimir Sementsov-Ogievskiy
2016-09-26 8:47 ` Kevin Wolf
2016-09-26 12:49 ` Paolo Bonzini
2016-09-24 13:42 ` Vladimir Sementsov-Ogievskiy
2016-09-24 16:20 ` Vladimir Sementsov-Ogievskiy
2016-09-24 16:35 ` Alex Bligh
2016-09-24 16:44 ` Vladimir Sementsov-Ogievskiy
2016-09-24 16:48 ` Vladimir Sementsov-Ogievskiy
2016-09-24 16:52 ` Alex Bligh
2016-09-24 17:01 ` Alex Bligh
2016-09-24 16:31 ` Alex Bligh
2016-09-24 16:42 ` Vladimir Sementsov-Ogievskiy [this message]
2016-09-24 16:49 ` Alex Bligh
2016-09-24 17:13 ` Vladimir Sementsov-Ogievskiy
2016-09-24 17:32 ` Alex Bligh
2016-09-24 17:47 ` Vladimir Sementsov-Ogievskiy
2016-09-24 18:24 ` Alex Bligh
2016-09-24 20:19 ` Vladimir Sementsov-Ogievskiy
2016-09-24 22:30 ` Wouter Verhelst
2016-09-24 17:33 ` Vladimir Sementsov-Ogievskiy
2016-09-24 20:14 ` [Qemu-devel] [Nbd] " Carl-Daniel Hailfinger
2016-09-24 20:32 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E6ACDD.7080205@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=alex@alex.org.uk \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.