From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Mon, 26 Sep 2016 10:33:53 +0530 Subject: [PATCH] phy: meson-usb2: Fix build dependency In-Reply-To: References: <1473991635-27973-1-git-send-email-axel.lin@ingics.com> <57E20743.3030408@ti.com> Message-ID: <57E8AC39.4010105@ti.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Wednesday 21 September 2016 09:43 AM, Axel Lin wrote: > 2016-09-21 12:06 GMT+08:00 Kishon Vijay Abraham I : >> >> >> On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote: >>> Martin Blumenstingl writes: >>> >>>> Hi Axel, >>>> >>>> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin wrote: >>>>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below >>>>> build error: >>>>> >>>>> drivers/built-in.o: In function `phy_meson_usb2_probe': >>>>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy' >>>>> Makefile:961: recipe for target 'vmlinux' failed >>>>> make: *** [vmlinux] Error 1 >>>>> >>>>> Signed-off-by: Axel Lin >>>>> --- >>>>> drivers/phy/Kconfig | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >>>>> index 6ad87ec..cc27c12 100644 >>>>> --- a/drivers/phy/Kconfig >>>>> +++ b/drivers/phy/Kconfig >>>>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2 >>>>> tristate "Meson USB2 PHY driver" >>>>> default ARCH_MESON >>>>> depends on OF && (ARCH_MESON || COMPILE_TEST) >>>>> + depends on USB_SUPPORT >>>>> + select USB_COMMON >>>>> select GENERIC_PHY >>>>> help >>>>> Enable this to support the Meson USB2 PHYs found in Meson8b >>>>> -- >>>>> 2.7.4 >>>>> >>>> thanks for this patch! >>>> >>>> How do we handle patches for drivers which will (unfortunately) not >>>> land in the linux 4.8 - should I integrate that into v3 of the patch >>>> (which I'll have to send anyways) or do we keep them separate? >>>> Maybe Kishon and/or Kevin can share their opinion on this. >> >> Since you are anyways planning to send v3, merge this patch too. > > I got confused why this driver appears in linux-next but it's not from phy > tree? I thought it's because other dependency so it needs to go via other tree, > but looks like not the case. And the driver does not get Kishon's Ack? > > BTW, Kishon, do you consider to add phy tree to linux-next? yes.. that's been pending for a long time. -Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753677AbcIZFE1 (ORCPT ); Mon, 26 Sep 2016 01:04:27 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:45955 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbcIZFEZ (ORCPT ); Mon, 26 Sep 2016 01:04:25 -0400 Subject: Re: [PATCH] phy: meson-usb2: Fix build dependency To: Axel Lin References: <1473991635-27973-1-git-send-email-axel.lin@ingics.com> <57E20743.3030408@ti.com> CC: Kevin Hilman , Martin Blumenstingl , Jerome Brunet , "linux-kernel@vger.kernel.org" , From: Kishon Vijay Abraham I Message-ID: <57E8AC39.4010105@ti.com> Date: Mon, 26 Sep 2016 10:33:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 21 September 2016 09:43 AM, Axel Lin wrote: > 2016-09-21 12:06 GMT+08:00 Kishon Vijay Abraham I : >> >> >> On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote: >>> Martin Blumenstingl writes: >>> >>>> Hi Axel, >>>> >>>> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin wrote: >>>>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below >>>>> build error: >>>>> >>>>> drivers/built-in.o: In function `phy_meson_usb2_probe': >>>>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy' >>>>> Makefile:961: recipe for target 'vmlinux' failed >>>>> make: *** [vmlinux] Error 1 >>>>> >>>>> Signed-off-by: Axel Lin >>>>> --- >>>>> drivers/phy/Kconfig | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >>>>> index 6ad87ec..cc27c12 100644 >>>>> --- a/drivers/phy/Kconfig >>>>> +++ b/drivers/phy/Kconfig >>>>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2 >>>>> tristate "Meson USB2 PHY driver" >>>>> default ARCH_MESON >>>>> depends on OF && (ARCH_MESON || COMPILE_TEST) >>>>> + depends on USB_SUPPORT >>>>> + select USB_COMMON >>>>> select GENERIC_PHY >>>>> help >>>>> Enable this to support the Meson USB2 PHYs found in Meson8b >>>>> -- >>>>> 2.7.4 >>>>> >>>> thanks for this patch! >>>> >>>> How do we handle patches for drivers which will (unfortunately) not >>>> land in the linux 4.8 - should I integrate that into v3 of the patch >>>> (which I'll have to send anyways) or do we keep them separate? >>>> Maybe Kishon and/or Kevin can share their opinion on this. >> >> Since you are anyways planning to send v3, merge this patch too. > > I got confused why this driver appears in linux-next but it's not from phy > tree? I thought it's because other dependency so it needs to go via other tree, > but looks like not the case. And the driver does not get Kishon's Ack? > > BTW, Kishon, do you consider to add phy tree to linux-next? yes.. that's been pending for a long time. -Kishon