From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030407AbcIZJ7Q (ORCPT ); Mon, 26 Sep 2016 05:59:16 -0400 Received: from mga01.intel.com ([192.55.52.88]:50015 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935768AbcIZJ7O (ORCPT ); Mon, 26 Sep 2016 05:59:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,398,1470726000"; d="scan'208";a="765993335" Subject: Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static To: Baoyou Xie , mathias.nyman@intel.com, gregkh@linuxfoundation.org References: <1474638373-27342-1-git-send-email-baoyou.xie@linaro.org> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@linaro.org, xie.baoyou@zte.com.cn From: Mathias Nyman Message-ID: <57E8F173.5040409@linux.intel.com> Date: Mon, 26 Sep 2016 12:59:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1474638373-27342-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.09.2016 16:46, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/usb/host/xhci-ring.c | 5 +++-- Hi There's a similar patch already pending, I'm sending that one forward after rc1 is out http://marc.info/?l=linux-usb&m=147170676714500&w=2 -Mathias