From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34114)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bprIs-0002zc-KE
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 02:28:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bprIn-0003vU-IJ
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 02:28:13 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:47760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bprIm-0003te-Sp
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 02:28:09 -0400
References: <1475138797-9908-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<20160930055334.GB1429@amit-lp.rh>
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Message-ID: <57EE05CE.2050407@huawei.com>
Date: Fri, 30 Sep 2016 14:27:26 +0800
MIME-Version: 1.0
In-Reply-To: <20160930055334.GB1429@amit-lp.rh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain
 LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: peter.huangpeng@huawei.com, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, Hai Huang <hhuang@redhat.com>, Weidong Han <hanweidong@huawei.com>, Dong eddie <eddie.dong@intel.com>, Stefan Hajnoczi <stefanha@redhat.com>, Jason Wang <jasowang@redhat.com>, Gui Jianfeng <GuiJianfeng@cn.fujitsu.com>

On 2016/9/30 13:53, Amit Shah wrote:
> On (Thu) 29 Sep 2016 [16:46:20], zhanghailiang wrote:
>> This is the 20th version of COLO frame series.
>>
>> COLO Block replication and proxy (COLO compare) series are both been
>> merged into upstream already. And further works can be done now to
>> realize the full COLO feature.
>>
>> Athough there are still no feedbacks from community for this part,
>> But I would like to rebase this series to the recent upstream.
>
Hi Amit，

Thanks for your prompt reply :)

> Thanks - I see most of the patches are reviewed by at least Dave, with
> a couple reviewed by Eric as well.
>
> I know Juan is compiling a pull req, and he'll reach out if there are
> concerns.
>

Great.

> In the meanwhile, can you check why the autobuilder fails to compile
> with your patchset?
>

Yes, It was related to the 9th patch, where i used %lu to print value of 'uint64_t' type
which is incorrect. I think it can be fixed by use 'PRIu64' to print uint64_t value.

The wrong codes are:
+        if (total_size != value) {
+            error_report("Got %lu VMState data, less than expected %lu",
+                         total_size, value);
+            goto out;
+        }

Fixed:
+        if (total_size != value) {
+            error_report("Got%" PRIu64 " VMState data, less than expected %" PRIu64,
+                         total_size, value);
+            goto out;
+        }


Should i resend this series with this be fixed now ?

Thanks.
hailiang

> Thanks,
>
> 		Amit
>
> .
>