From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40195)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bprub-0000re-VC
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 03:07:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bpruW-000686-Tn
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 03:07:12 -0400
Received: from [59.151.112.132] (port=37949 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bpruU-00065z-KY
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 03:07:08 -0400
References: <1473839464-8670-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1473839464-8670-4-git-send-email-caoj.fnst@cn.fujitsu.com>
	<874m4y94dx.fsf@dusky.pond.sub.org> <57EDFBC5.8020203@cn.fujitsu.com>
	<87r381vpkh.fsf@dusky.pond.sub.org>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <57EE0F46.3000909@cn.fujitsu.com>
Date: Fri, 30 Sep 2016 15:07:50 +0800
MIME-Version: 1.0
In-Reply-To: <87r381vpkh.fsf@dusky.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 3/8] pci: Convert msix_init() to Error
 and fix callers to check it
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jiri Pirko <jiri@resnulli.us>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Dmitry Fleytman <dmitry@daynix.com>, Alex Williamson <alex.williamson@redhat.com>, Hannes Reinecke <hare@suse.de>, Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>



On 09/30/2016 03:01 PM, Markus Armbruster wrote:
> Cao jin <caoj.fnst@cn.fujitsu.com> writes:
>
>> On 09/29/2016 10:17 PM, Markus Armbruster wrote:

>>>
>>> Intentional change?  I like the old one better.
>>>
>>
>> Oh...it was lost by me. I was planning move these comments into a
>> separate patch, but later feel that it is not worth the trouble, so I
>> undo the movement, it is lost during the process.
>
> Let's restore it then.
>

sure, I will send new version to fix all these comments, after get 
confirmation from Dmitry about the last patch: vmxnet3

-- 
Yours Sincerely,

Cao jin