From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vishwanath Pai Subject: Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division Date: Fri, 30 Sep 2016 13:58:03 -0400 Message-ID: <57EEA7AB.3010301@akamai.com> References: <20160929173950.GA27689@akamai.com> <20160930174650.GE1176@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: johunt@akamai.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, pai.vishwain@gmail.com, kaber@trash.net, kadlec@blackhole.kfki.hu, zlpnobody@gmail.com, hannes@stressinduktion.org, maze@google.com, eric.dumazet@gmail.com, akpm@linux-foundation.org To: Pablo Neira Ayuso Return-path: In-Reply-To: <20160930174650.GE1176@salvia> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On 09/30/2016 01:46 PM, Pablo Neira Ayuso wrote: > On Thu, Sep 29, 2016 at 01:39:50PM -0400, Vishwanath Pai wrote: >> v2: >> Remove unnecessary div64_u64 around constants >> >> v3: >> remove backslashes >> >> -- >> >> Fix link error in 32bit arch because of 64bit division >> >> Division of 64bit integers will cause linker error undefined reference >> to `__udivdi3'. Fix this by replacing divisions with div64_64 > > Applied, thanks Pai. > >> Signed-off-by: Vishwanath Pai >> Fixes: 11d5f15723c9 ("netfilter: xt_hashlimit: Create revision 2 to ...") >> >> --- > > Please, next time place the versioning information here, otherwise git > am takes the wrong description here. > Thank you. And sorry about, I did not realize git am would put that into the description. -Vishwanath