From: Mike Looijmans <mike.looijmans@topic.nl>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode
Date: Mon, 3 Oct 2016 18:30:17 +0200 [thread overview]
Message-ID: <57F28799.7030701@topic.nl> (raw)
In-Reply-To: <20161003143508.GA26382@lunn.ch>
On 03-10-16 16:35, Andrew Lunn wrote:
>> + Boolean:
>> +
>> + - enable-edpd : Not related to timing. Specify this property to enable
>> + energy-detect power-down mode in the PHY.
>
> The Broadcom PHYs unconditionally enable this feature.
>
> The SMSC driver has an option: smsc,disable-energy-detect because it
> seems to have a rare hardware bug when it is enabled.
>
> And you would like to make it off by default.
>
> Could we avoid having three drivers doing three different things?
> Could you have it unconditionally on, and see if anybody reports it
> being broken?
Good suggestion I think. It's a feature found on many PHYs, apparently
without any ill effects, so just enabling unconditionally simplifies
things. And it's good for the environment...
I'll post a v2 patch (which won't need devicetree changes then).
--
Mike Looijmans
next prev parent reply other threads:[~2016-10-03 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 13:04 [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode Mike Looijmans
[not found] ` <1475499870-11465-1-git-send-email-mike.looijmans-Oq418RWZeHk@public.gmane.org>
2016-10-03 14:35 ` Andrew Lunn
2016-10-03 14:35 ` Andrew Lunn
2016-10-03 16:30 ` Mike Looijmans [this message]
2016-10-04 5:52 ` [PATCH v2] phy: micrel.c: Enable " Mike Looijmans
2016-10-04 6:55 ` Andrew Lunn
2016-10-04 11:09 ` Florian Fainelli
2016-10-06 1:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57F28799.7030701@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.