All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rahul Bedarkar <Rahul.Bedarkar@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] elfutils: clarify licensing info
Date: Tue, 4 Oct 2016 18:31:40 +0530	[thread overview]
Message-ID: <57F3A834.6090300@imgtec.com> (raw)
In-Reply-To: <1475577852-15870-1-git-send-email-gustavo.zacarias@free-electrons.com>

Hi,

On Tuesday 04 October 2016 04:14 PM, gustavo.zacarias at free-electrons.com 
wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
>
> elfutils libraries are GPLv2 or LGPLv3+, standalone programs are GPLv3+
> (see the NEWS file).
> Make the GPLv3+ license tag/file dependant on the programs being
> enabled, and make the GPLv2/LGPLv3+ tag more descriptive.
>

License string should be GPLv2+ instead of GPLv2 because license header 
uses clause "either version 2 of the License, or (at your option) any 
later version". With that license string for library is "GPLv2+ or LGPLv3+"

> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
>   package/elfutils/elfutils.mk | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/package/elfutils/elfutils.mk b/package/elfutils/elfutils.mk
> index 6af1223..5026474 100644
> --- a/package/elfutils/elfutils.mk
> +++ b/package/elfutils/elfutils.mk
> @@ -8,10 +8,16 @@ ELFUTILS_VERSION = 0.166
>   ELFUTILS_SOURCE = elfutils-$(ELFUTILS_VERSION).tar.bz2
>   ELFUTILS_SITE = https://fedorahosted.org/releases/e/l/elfutils/$(ELFUTILS_VERSION)
>   ELFUTILS_INSTALL_STAGING = YES
> -ELFUTILS_LICENSE = GPLv3, GPLv2, LGPLv3
> -ELFUTILS_LICENSE_FILES = COPYING COPYING-GPLV2 COPYING-LGPLV3
> +ELFUTILS_LICENSE = GPLv2 or LGPLv3+ (library)

As mentioned above it should be

ELFUTILS_LICENSE = GPLv2+ or LGPLv3+ (library)

> +ELFUTILS_LICENSE_FILES = COPYING-GPLV2 COPYING-LGPLV3
>   ELFUTILS_DEPENDENCIES = zlib
>
> +# Programs are GPLv3+ so add it when they're enabled
> +ifeq ($(BR2_PACKAGE_ELFUTILS_PROGS),y)

There is same if condition down. Instead we should conditionally add 
license there.

> +ELFUTILS_LICENSE += GPLv3+ (programs)

Since it is separate component, it should be comma separated.

ELFUTILS_LICENSE := $(ELFUTILS_LICENSE), GPLv3+ (programs)


Regards,
Rahul

  reply	other threads:[~2016-10-04 13:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 10:44 [Buildroot] [PATCH] elfutils: clarify licensing info gustavo.zacarias at free-electrons.com
2016-10-04 13:01 ` Rahul Bedarkar [this message]
2016-10-04 23:06   ` Gustavo Zacarias
2016-10-05  6:46     ` Rahul Bedarkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57F3A834.6090300@imgtec.com \
    --to=rahul.bedarkar@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.