From: Timur Tabi <timur@codeaurora.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA
Date: Thu, 6 Oct 2016 09:06:43 -0500 [thread overview]
Message-ID: <57F65A73.7020701@codeaurora.org> (raw)
In-Reply-To: <1475762253-16759-1-git-send-email-geert@linux-m68k.org>
Geert Uytterhoeven wrote:
> config QCOM_EMAC
> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
> + depends on HAS_DMA
I think it needs to depend on HAS_IOMEM as well, to fix this error in
arch/um:
drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit
declaration of function 'iounmap' [-Werror=implicit-function-declaration]
iounmap(adpt->phy.digital);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-10-06 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:57 [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven
2016-10-06 14:06 ` Timur Tabi [this message]
2016-10-06 14:10 ` Geert Uytterhoeven
2016-10-06 14:10 ` Geert Uytterhoeven
2016-10-06 14:12 ` Timur Tabi
2016-10-06 14:45 ` Geert Uytterhoeven
2016-10-06 14:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57F65A73.7020701@codeaurora.org \
--to=timur@codeaurora.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.