From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bt2oe-0008SM-JM
	for qemu-devel@nongnu.org; Sat, 08 Oct 2016 21:22:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bt2oa-0006uW-A5
	for qemu-devel@nongnu.org; Sat, 08 Oct 2016 21:22:11 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:40035)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bt2oZ-0006sy-KZ
	for qemu-devel@nongnu.org; Sat, 08 Oct 2016 21:22:08 -0400
References: <1475138797-9908-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<20160930055334.GB1429@amit-lp.rh> <57EE05CE.2050407@huawei.com>
	<20161005121343.GB2272@amit-lp.rh>
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Message-ID: <57F99BA0.1070905@huawei.com>
Date: Sun, 9 Oct 2016 09:21:36 +0800
MIME-Version: 1.0
In-Reply-To: <20161005121343.GB2272@amit-lp.rh>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain
 LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: peter.huangpeng@huawei.com, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, Hai Huang <hhuang@redhat.com>, Weidong Han <hanweidong@huawei.com>, Dong eddie <eddie.dong@intel.com>, Stefan Hajnoczi <stefanha@redhat.com>, Jason Wang <jasowang@redhat.com>, Gui Jianfeng <GuiJianfeng@cn.fujitsu.com>

On 2016/10/5 20:13, Amit Shah wrote:
> On (Fri) 30 Sep 2016 [14:27:26], Hailiang Zhang wrote:
>> On 2016/9/30 13:53, Amit Shah wrote:
>
>>> In the meanwhile, can you check why the autobuilder fails to compile
>>> with your patchset?
>>>
>>
>> Yes, It was related to the 9th patch, where i used %lu to print value of 'uint64_t' type
>> which is incorrect. I think it can be fixed by use 'PRIu64' to print uint64_t value.
>>
>> The wrong codes are:
>> +        if (total_size != value) {
>> +            error_report("Got %lu VMState data, less than expected %lu",
>> +                         total_size, value);
>> +            goto out;
>> +        }
>>
>> Fixed:
>> +        if (total_size != value) {
>> +            error_report("Got%" PRIu64 " VMState data, less than expected %" PRIu64,
>> +                         total_size, value);
>> +            goto out;
>> +        }
>>
>>
>> Should i resend this series with this be fixed now ?
>
> It's easier if you resend, that way it reduces the maintainer's burden
> and makes reviewing/applying patches faster!
>

OK, I'll resend this series later, I saw Juan has sent a pull request,
It seems that some patches in that series conflicts with this patch-set,
I'll update this series based on that series.

Thanks,
Hailiang

>
> 		Amit
>
> .
>