From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhoucm1 Subject: Re: [PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path Date: Mon, 10 Oct 2016 15:11:54 +0800 Message-ID: <57FB3F3A.7070902@amd.com> References: <1475696538-24754-1-git-send-email-alexander.deucher@amd.com> <5f17b1d4-b088-4ed7-06b7-86b4c85bd4f0@vodafone.de> <9a09b439-600b-ed25-4d1c-3ee12848a6d8@vodafone.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0880805993==" Return-path: In-Reply-To: <9a09b439-600b-ed25-4d1c-3ee12848a6d8-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Tom St Denis , Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Deucher --===============0880805993== Content-Type: multipart/alternative; boundary="------------090102090200090801050203" --------------090102090200090801050203 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit We can make it dGpu specific if APU has no problem. Regards, David Zhou On 2016年10月10日 15:09, Christian König wrote: >> i'm a trailblazer of bad ideas at times :-) hehehehe > Well, I know this because I had the same bad idea earlier and spend a > lot of time bisecting why it broke :) > > Christian. > > Am 09.10.2016 um 19:54 schrieb Tom St Denis: >> Yup that's what I said in another part of the thread :-) >> >> i'm a trailblazer of bad ideas at times :-) hehehehe >> >> Tom >> >> On Sun, Oct 9, 2016 at 11:13 AM Christian König >> > wrote: >> >> Am 05.10.2016 um 21:42 schrieb Alex Deucher: >> > Looks like fallout from a rebase or merge. >> > >> > Signed-off-by: Alex Deucher > > >> >> NAK, this is done on purpose and is for evicting the GART table using >> memcpy. >> >> Tom wanted to remove that as well and it makes resume then fail >> horrible >> on dGPUs. >> >> We should probably add a comment why this is necessary. >> >> Christian. >> >> > --- >> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 --- >> > 1 file changed, 3 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >> > index 45259b5..c2f70be 100644 >> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >> > @@ -1956,9 +1956,6 @@ int amdgpu_device_suspend(struct >> drm_device *dev, bool suspend, bool fbcon) >> > >> > r = amdgpu_suspend(adev); >> > >> > - /* evict remaining vram memory */ >> > - amdgpu_bo_evict_vram(adev); >> > - >> > pci_save_state(dev->pdev); >> > if (suspend) { >> > /* Shut down the device */ >> >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx --------------090102090200090801050203 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit We can make it dGpu specific if APU has no problem.

Regards,
David Zhou

On 2016年10月10日 15:09, Christian König wrote:
i'm a trailblazer of bad ideas at times :-) hehehehe
Well, I know this because I had the same bad idea earlier and spend a lot of time bisecting why it broke :)

Christian.

Am 09.10.2016 um 19:54 schrieb Tom St Denis:
Yup that's what I said in another part of the thread :-)

i'm a trailblazer of bad ideas at times :-) hehehehe

Tom

On Sun, Oct 9, 2016 at 11:13 AM Christian König <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> wrote:
Am 05.10.2016 um 21:42 schrieb Alex Deucher:
> Looks like fallout from a rebase or merge.
>
> Signed-off-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

NAK, this is done on purpose and is for evicting the GART table using
memcpy.

Tom wanted to remove that as well and it makes resume then fail horrible
on dGPUs.

We should probably add a comment why this is necessary.

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 45259b5..c2f70be 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1956,9 +1956,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool suspend, bool fbcon)
>
>       r = amdgpu_suspend(adev);
>
> -     /* evict remaining vram memory */
> -     amdgpu_bo_evict_vram(adev);
> -
>       pci_save_state(dev->pdev);
>       if (suspend) {
>               /* Shut down the device */


_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

--------------090102090200090801050203-- --===============0880805993== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============0880805993==--