Re: [PATCH] ASoC: samsung: Minor simplification in i2s_set_fmt()

[Tobias Jakobi <tjakobi@math.uni-bielefeld.de>]

Hello,


Sylwester Nawrocki wrote:
> On 10/10/2016 04:04 AM, Tobias Jakobi wrote:
>> From: Michael McConville <mmcco@mykolab.com>
>>
>> We can replace the if-statement with the simpler bit
>> toggle operation.
> 
>> Changes in v2:
>> - add proper commit header and description
> 
> Thanks for the patch. The above 2 lines should be moved past the
> scissors "---" line below.
should I resend, or can this be fixed on merge?

- Tobias


>> Signed-off-by: Michael McConville <mmcco@mykolab.com>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> 
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
>> ---
> 
>>  sound/soc/samsung/i2s.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
>> index 50635ee..1c484ac 100644
>> --- a/sound/soc/samsung/i2s.c
>> +++ b/sound/soc/samsung/i2s.c
>> @@ -627,10 +627,7 @@ static int i2s_set_fmt(struct snd_soc_dai *dai,
>>  	case SND_SOC_DAIFMT_NB_NF:
>>  		break;
>>  	case SND_SOC_DAIFMT_NB_IF:
>> -		if (tmp & lrp_rlow)
>> -			tmp &= ~lrp_rlow;
>> -		else
>> -			tmp |= lrp_rlow;
>> +		tmp ^= lrp_rlow;
>>  		break;
>>  	default:
>>  		dev_err(&i2s->pdev->dev, "Polarity not supported\n");
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>