From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Dmitry Fleytman <dmitry@daynix.com>,
Markus Armbruster <armbru@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag
Date: Tue, 11 Oct 2016 11:35:26 +0800 [thread overview]
Message-ID: <57FC5DFE.4070708@cn.fujitsu.com> (raw)
In-Reply-To: <017DDFF7-F80A-4C07-B533-4BEBEEA641CE@daynix.com>
On 10/06/2016 05:39 PM, Dmitry Fleytman wrote:
>
>
> Hello,
>
> Yes, from what I see, this call is wrong and leads to
> reference leaks on device unload at migration target.
> It should be removed.
>
> Best regards,
> Dmitry
>
Hi,Dmitry
From what I saw, current code will call msix_vector_use twice on
migration target, which is wrong. I am not quite follow you on
"reference leak", are you saying the same thing as me? if not, could you
help to explain more?
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-10-11 3:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 7:50 [Qemu-devel] [PATCH v3 0/8] Convert msix_init() to error Cao jin
2016-09-14 7:50 ` [Qemu-devel] [PATCH v3 1/8] msix: Follow CODING_STYLE Cao jin
2016-09-14 7:50 ` [Qemu-devel] [PATCH v3 2/8] hcd-xhci: check & correct param before using it Cao jin
2016-09-29 13:47 ` Markus Armbruster
2016-09-29 15:21 ` Gerd Hoffmann
2016-09-14 7:50 ` [Qemu-devel] [PATCH v3 3/8] pci: Convert msix_init() to Error and fix callers to check it Cao jin
2016-09-29 14:17 ` Markus Armbruster
2016-09-30 5:44 ` Cao jin
2016-09-30 7:01 ` Markus Armbruster
2016-09-30 7:07 ` Cao jin
2016-09-14 7:51 ` [Qemu-devel] [PATCH v3 4/8] megasas: change behaviour of msix switch Cao jin
2016-09-14 7:51 ` [Qemu-devel] [PATCH v3 5/8] hcd-xhci: " Cao jin
2016-09-29 14:32 ` Markus Armbruster
2016-09-29 15:22 ` Gerd Hoffmann
2016-09-14 7:51 ` [Qemu-devel] [PATCH v3 6/8] megasas: remove unnecessary megasas_use_msix() Cao jin
2016-09-29 14:35 ` Markus Armbruster
2016-09-30 6:09 ` Cao jin
2016-09-30 7:01 ` Markus Armbruster
2016-09-14 7:51 ` [Qemu-devel] [PATCH v3 7/8] megasas: undo the overwrites of msi user configuration Cao jin
2016-09-14 7:51 ` [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag Cao jin
2016-09-29 14:42 ` Markus Armbruster
2016-09-30 6:58 ` Cao jin
2016-09-30 13:08 ` Markus Armbruster
2016-10-06 9:39 ` Dmitry Fleytman
2016-10-06 15:43 ` Dr. David Alan Gilbert
2016-10-06 19:33 ` Dmitry Fleytman
2016-10-11 3:35 ` Cao jin [this message]
2016-10-11 4:18 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57FC5DFE.4070708@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.