From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex
Date: Wed, 12 Oct 2016 18:32:03 +0800 [thread overview]
Message-ID: <57FE1123.9090302@cn.fujitsu.com> (raw)
In-Reply-To: <1476267508-19499-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
On 10/12/2016 06:18 PM, Changlong Xie wrote:
> ----------------------------------------------------------------------------------------
> time request Actions
> 29 15(most case) in_flight=15, Coroutine=C15, free_sema->holder=C17, mutex->locked=false
> ----------------------------------------------------------------------------------------
>
> Per Paolo's suggestion "The simplest fix is to change it to CoQueue, which is like a condition
> variable", this patch replaces CoMutex with CoQueue.
>
> Cc: Wen Congyang<wency@cn.fujitsu.com>
> Reported-by: zhanghailiang<zhang.zhanghailiang@huawei.com>
> Suggested-by: Paolo Bonzini<pbonzini@redhat.com>
> Signed-off-by: Changlong Xie<xiecl.fnst@cn.fujitsu.com>
> ---
Please refer to:
http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg02172.html
next prev parent reply other threads:[~2016-10-12 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 10:18 [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex Changlong Xie
2016-10-12 10:32 ` Changlong Xie [this message]
2016-10-12 10:53 ` Paolo Bonzini
2016-10-24 1:44 ` Changlong Xie
2016-10-24 9:36 ` Paolo Bonzini
2016-10-25 2:09 ` Changlong Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57FE1123.9090302@cn.fujitsu.com \
--to=xiecl.fnst@cn.fujitsu.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.