From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932983AbcJLOpE (ORCPT ); Wed, 12 Oct 2016 10:45:04 -0400 Received: from mga04.intel.com ([192.55.52.120]:49344 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932617AbcJLOo4 (ORCPT ); Wed, 12 Oct 2016 10:44:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,482,1473145200"; d="scan'208";a="18818926" Subject: Re: [PATCH v2 2/4] Add enabling of the R3 MWAIT during boot for KNL To: Thomas Gleixner , Grzegorz Andrejczuk References: <1476274585-21679-1-git-send-email-grzegorz.andrejczuk@intel.com> <1476274585-21679-3-git-send-email-grzegorz.andrejczuk@intel.com> Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, linux-kernel@vger.kernel.org, lukasz.daniluk@intel.com, james.h.cownie@intel.com From: Dave Hansen Message-ID: <57FE4984.9070408@linux.intel.com> Date: Wed, 12 Oct 2016 07:32:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2016 06:35 AM, Thomas Gleixner wrote: > On Wed, 12 Oct 2016, Grzegorz Andrejczuk wrote: >> > + /* >> > + * Setting ring 3 MONITOR/MWAIT for all threads >> > + * when CPU is Xeon Phi Family x200 >> > + * This can be disabled with phir3mwait=disable cmdline switch. >> > + * We preserve the reserved values and set only 2nd bit. >> > + * Ref: >> > + * https://software.intel.com/en-us/blogs/2016/10/06/intel-xeon-phi-product-family-x200-knl-user-mode-ring-3-monitor-and-mwait > Please don't put links like this into comments. They are stale before this > hits Linus tree. Yeah, I'm worried about this too. It's probably best to include some version of the text in that blog entry, or that text itself. That way, when Intel reorganizes and culls old blog entries, we won't completely lose our source.