All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] error reporting in functions
Date: Wed, 12 Oct 2016 18:47:53 +0300	[thread overview]
Message-ID: <57FE5B29.4040808@virtuozzo.com> (raw)

HI all!

My questions is: what are general recommendations in Qemu for return 
code, if we have Error **errp?
What should I prefer: errp, duplicated by int return code, or void 
functions with errp?

void + errp seems good, just to not duplicate things. But it has a 
disadvantage of necessity of "local_err" and "error_propagate" in caller 
function, if its behaviour depends on callee function success...

-- 
Best regards,
Vladimir

             reply	other threads:[~2016-10-12 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 15:47 Vladimir Sementsov-Ogievskiy [this message]
2016-10-12 20:55 ` [Qemu-devel] error reporting in functions Eric Blake
2016-10-13  6:39   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57FE5B29.4040808@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.