From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 13 Oct 2016 09:02:26 +0200 (CEST) Received: from mailapp02.imgtec.com ([217.156.133.132]:29966 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23992143AbcJMHCT4B3Dt (ORCPT ); Thu, 13 Oct 2016 09:02:19 +0200 Received: from HHMAIL03.hh.imgtec.org (unknown [10.44.0.21]) by Forcepoint Email with ESMTPS id A62FC12A5305; Thu, 13 Oct 2016 08:02:10 +0100 (IST) Received: from PUMAIL01.pu.imgtec.org (192.168.91.250) by HHMAIL03.hh.imgtec.org (10.44.0.21) with Microsoft SMTP Server (TLS) id 14.3.294.0; Thu, 13 Oct 2016 08:02:12 +0100 Received: from [192.168.91.23] (192.168.91.23) by PUMAIL01.pu.imgtec.org (192.168.91.250) with Microsoft SMTP Server (TLS) id 14.3.266.1; Thu, 13 Oct 2016 12:32:10 +0530 Subject: Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board To: Rob Herring References: <1475757094-31089-1-git-send-email-rahul.bedarkar@imgtec.com> <1475757094-31089-2-git-send-email-rahul.bedarkar@imgtec.com> <20161010142152.GA7920@rob-hp-laptop> CC: Ralf Baechle , Mark Rutland , James Hartley , , , From: Rahul Bedarkar Message-ID: <57FF3172.4010709@imgtec.com> Date: Thu, 13 Oct 2016 12:32:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20161010142152.GA7920@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.91.23] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 55416 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Rahul.Bedarkar@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi, On Monday 10 October 2016 07:51 PM, Rob Herring wrote: >> + >> + memory { > > Is 0 the actual base, or that gets filled in by bootloader? If the > formet, add unit address. > Bootloader (uboot) can override or fixup memory node. But with version of bootloader I tested with, base address is hardcoded to 0 and only size may get changed. But since booloader can override or fixup memory node, I assume we don't add unit address in this case. >> + device_type = "memory"; >> + reg = <0x00000000 0x08000000>; I now realized that size is incorrectly specified in memory node. It should be 256MB and not 128MB. I will fix this in v2. Thanks, Rahul From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp02.imgtec.com ([217.156.133.132]:29966 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23992143AbcJMHCT4B3Dt (ORCPT ); Thu, 13 Oct 2016 09:02:19 +0200 Subject: Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board References: <1475757094-31089-1-git-send-email-rahul.bedarkar@imgtec.com> <1475757094-31089-2-git-send-email-rahul.bedarkar@imgtec.com> <20161010142152.GA7920@rob-hp-laptop> From: Rahul Bedarkar Message-ID: <57FF3172.4010709@imgtec.com> Date: Thu, 13 Oct 2016 12:32:10 +0530 MIME-Version: 1.0 In-Reply-To: <20161010142152.GA7920@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Rob Herring Cc: Ralf Baechle , Mark Rutland , James Hartley , linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20161013070210.nr_hpY979FfEA6vEHi9v8aXO2TcDuQ2U_xRDsX5JcK0@z> Hi, On Monday 10 October 2016 07:51 PM, Rob Herring wrote: >> + >> + memory { > > Is 0 the actual base, or that gets filled in by bootloader? If the > formet, add unit address. > Bootloader (uboot) can override or fixup memory node. But with version of bootloader I tested with, base address is hardcoded to 0 and only size may get changed. But since booloader can override or fixup memory node, I assume we don't add unit address in this case. >> + device_type = "memory"; >> + reg = <0x00000000 0x08000000>; I now realized that size is incorrectly specified in memory node. It should be 256MB and not 128MB. I will fix this in v2. Thanks, Rahul