diff for duplicates of <57FF5380.1080704@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 9c5125e..1980e69 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,7 +4,7 @@ Am 13.10.2016 10:55, schrieb Dan Carpenter: > We want to read 3 bytes here, but because the parenthesis are in the > wrong place we instead read: > -> sizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd) +> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd) > > which is one byte. > @@ -19,9 +19,9 @@ Am 13.10.2016 10:55, schrieb Dan Carpenter: > /* Read the eDP Display control capabilities registers */ > if ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) && > drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV, -> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) = +> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) == > - sizeof(intel_dp->edp_dpcd))) -> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) = +> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) == > + sizeof(intel_dp->edp_dpcd)) @@ -31,7 +31,7 @@ perhaps we can morph that into something more readable ? I would suggest: if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) { - size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */ + size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */ int ret; ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size); @@ -51,4 +51,8 @@ this way it improves readability and reduces line length. > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -> +> +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N1/content_digest index fe7dbd9..f1ee14e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020161013085508.GJ16198@mwanda\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] drm/i915: fix a read size argument\0" - "Date\0Thu, 13 Oct 2016 09:27:28 +0000\0" + "Date\0Thu, 13 Oct 2016 11:27:28 +0200\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0intel-gfx@lists.freedesktop.org" kernel-janitors@vger.kernel.org @@ -16,7 +16,7 @@ "> We want to read 3 bytes here, but because the parenthesis are in the\n" "> wrong place we instead read:\n" "> \n" - "> \tsizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd)\n" + "> \tsizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)\n" "> \n" "> which is one byte.\n" "> \n" @@ -31,9 +31,9 @@ "> \t/* Read the eDP Display control capabilities registers */\n" "> \tif ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) &&\n" "> \t drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,\n" - "> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) =\n" + "> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) ==\n" "> -\t\t\t sizeof(intel_dp->edp_dpcd)))\n" - "> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) =\n" + "> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==\n" "> +\t\t\t sizeof(intel_dp->edp_dpcd))\n" "\n" "\n" @@ -43,7 +43,7 @@ "\n" "if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE)\n" " {\n" - " size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */\n" + " size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */\n" " int ret;\t\n" "\n" " ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size);\t\n" @@ -63,6 +63,10 @@ "> To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" "> the body of a message to majordomo@vger.kernel.org\n" "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" - > + "> \n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -1d8b0b629123f02e6b853f347e2b6de0e5bfe459975d2d49411b91887bdfd304 +a238bc3c7b61545284489eed902e293ed70476f91c62ec37e0eeb851ec3dfe78
diff --git a/a/1.txt b/N2/1.txt index 9c5125e..334dd7a 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -4,7 +4,7 @@ Am 13.10.2016 10:55, schrieb Dan Carpenter: > We want to read 3 bytes here, but because the parenthesis are in the > wrong place we instead read: > -> sizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd) +> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd) > > which is one byte. > @@ -19,9 +19,9 @@ Am 13.10.2016 10:55, schrieb Dan Carpenter: > /* Read the eDP Display control capabilities registers */ > if ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) && > drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV, -> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) = +> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) == > - sizeof(intel_dp->edp_dpcd))) -> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) = +> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) == > + sizeof(intel_dp->edp_dpcd)) @@ -31,7 +31,7 @@ perhaps we can morph that into something more readable ? I would suggest: if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) { - size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */ + size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */ int ret; ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size); diff --git a/a/content_digest b/N2/content_digest index fe7dbd9..b6f27ab 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,13 +1,16 @@ "ref\020161013085508.GJ16198@mwanda\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] drm/i915: fix a read size argument\0" - "Date\0Thu, 13 Oct 2016 09:27:28 +0000\0" + "Date\0Thu, 13 Oct 2016 11:27:28 +0200\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Cc\0intel-gfx@lists.freedesktop.org" - kernel-janitors@vger.kernel.org - linux-kernel@vger.kernel.org + "Cc\0Daniel Vetter <daniel.vetter@intel.com>" + " Ville Syrj\303\244l\303\244 <ville.syrjala@linux.intel.com>" + Jani Nikula <jani.nikula@linux.intel.com> + David Airlie <airlied@linux.ie> + intel-gfx@lists.freedesktop.org dri-devel@lists.freedesktop.org - " Daniel Vetter <daniel.vetter@intel.com>\0" + linux-kernel@vger.kernel.org + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "\n" @@ -16,7 +19,7 @@ "> We want to read 3 bytes here, but because the parenthesis are in the\n" "> wrong place we instead read:\n" "> \n" - "> \tsizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd)\n" + "> \tsizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)\n" "> \n" "> which is one byte.\n" "> \n" @@ -31,9 +34,9 @@ "> \t/* Read the eDP Display control capabilities registers */\n" "> \tif ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) &&\n" "> \t drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,\n" - "> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) =\n" + "> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) ==\n" "> -\t\t\t sizeof(intel_dp->edp_dpcd)))\n" - "> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) =\n" + "> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==\n" "> +\t\t\t sizeof(intel_dp->edp_dpcd))\n" "\n" "\n" @@ -43,7 +46,7 @@ "\n" "if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE)\n" " {\n" - " size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */\n" + " size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */\n" " int ret;\t\n" "\n" " ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size);\t\n" @@ -65,4 +68,4 @@ "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" > -1d8b0b629123f02e6b853f347e2b6de0e5bfe459975d2d49411b91887bdfd304 +c4cd4ab80deaf2e3b371edf10e99ae209d2af35363449e2788dbd6b3d527427c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.