From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Jakobi Date: Thu, 13 Oct 2016 11:05:00 +0000 Subject: Re: [patch] drm/exynos: fix a timeout loop Message-Id: <57FF6A5C.6060108@math.uni-bielefeld.de> List-Id: References: <20161013102040.GA5576@mwanda> In-Reply-To: <20161013102040.GA5576@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Inki Dae , Tobias Jakobi Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org Hello Dan, sorry for the blunder! Patch looks good to me. Reviewed-by: Tobias Jakobi With best wishes, Tobias Dan Carpenter wrote: > We were trying to print an error message if we timed out here, but the > loop actually ends with "tries" set to UINT_MAX and not zero. Fix this > by changing from tries-- to --tries. > > A for loop would actually be the most natural way to do this. My fix > means we only loop 99 times instead of 100 but that's probably ok. > > Fixes: a696394c5224 ('drm/exynos: mixer: simplify loop in vp_win_reset()') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c > index edb20a3..fcc7e4f 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -701,7 +701,7 @@ static void vp_win_reset(struct mixer_context *ctx) > unsigned int tries = 100; > > vp_reg_write(res, VP_SRESET, VP_SRESET_PROCESSING); > - while (tries--) { > + while (--tries) { > /* waiting until VP_SRESET_PROCESSING is 0 */ > if (~vp_reg_read(res, VP_SRESET) & VP_SRESET_PROCESSING) > break; > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Jakobi Subject: Re: [patch] drm/exynos: fix a timeout loop Date: Thu, 13 Oct 2016 13:05:00 +0200 Message-ID: <57FF6A5C.6060108@math.uni-bielefeld.de> References: <20161013102040.GA5576@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161013102040.GA5576@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Inki Dae , Tobias Jakobi Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org List-Id: linux-samsung-soc@vger.kernel.org SGVsbG8gRGFuLAoKc29ycnkgZm9yIHRoZSBibHVuZGVyISBQYXRjaCBsb29rcyBnb29kIHRvIG1l LgoKUmV2aWV3ZWQtYnk6IFRvYmlhcyBKYWtvYmkgPHRqYWtvYmlAbWF0aC51bmktYmllbGVmZWxk LmRlPgoKCldpdGggYmVzdCB3aXNoZXMsClRvYmlhcwoKCkRhbiBDYXJwZW50ZXIgd3JvdGU6Cj4g V2Ugd2VyZSB0cnlpbmcgdG8gcHJpbnQgYW4gZXJyb3IgbWVzc2FnZSBpZiB3ZSB0aW1lZCBvdXQg aGVyZSwgYnV0IHRoZQo+IGxvb3AgYWN0dWFsbHkgZW5kcyB3aXRoICJ0cmllcyIgc2V0IHRvIFVJ TlRfTUFYIGFuZCBub3QgemVyby4gIEZpeCB0aGlzCj4gYnkgY2hhbmdpbmcgZnJvbSB0cmllcy0t IHRvIC0tdHJpZXMuCj4gCj4gQSBmb3IgbG9vcCB3b3VsZCBhY3R1YWxseSBiZSB0aGUgbW9zdCBu YXR1cmFsIHdheSB0byBkbyB0aGlzLiAgTXkgZml4Cj4gbWVhbnMgd2Ugb25seSBsb29wIDk5IHRp bWVzIGluc3RlYWQgb2YgMTAwIGJ1dCB0aGF0J3MgcHJvYmFibHkgb2suCj4gCj4gRml4ZXM6IGE2 OTYzOTRjNTIyNCAoJ2RybS9leHlub3M6IG1peGVyOiBzaW1wbGlmeSBsb29wIGluIHZwX3dpbl9y ZXNldCgpJykKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9y YWNsZS5jb20+Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9z X21peGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19taXhlci5jCj4gaW5kZXgg ZWRiMjBhMy4uZmNjN2U0ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4 eW5vc19taXhlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfbWl4ZXIu Ywo+IEBAIC03MDEsNyArNzAxLDcgQEAgc3RhdGljIHZvaWQgdnBfd2luX3Jlc2V0KHN0cnVjdCBt aXhlcl9jb250ZXh0ICpjdHgpCj4gIAl1bnNpZ25lZCBpbnQgdHJpZXMgPSAxMDA7Cj4gIAo+ICAJ dnBfcmVnX3dyaXRlKHJlcywgVlBfU1JFU0VULCBWUF9TUkVTRVRfUFJPQ0VTU0lORyk7Cj4gLQl3 aGlsZSAodHJpZXMtLSkgewo+ICsJd2hpbGUgKC0tdHJpZXMpIHsKPiAgCQkvKiB3YWl0aW5nIHVu dGlsIFZQX1NSRVNFVF9QUk9DRVNTSU5HIGlzIDAgKi8KPiAgCQlpZiAofnZwX3JlZ19yZWFkKHJl cywgVlBfU1JFU0VUKSAmIFZQX1NSRVNFVF9QUk9DRVNTSU5HKQo+ICAJCQlicmVhazsKPiAtLQo+ IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmli ZSBsaW51eC1zYW1zdW5nLXNvYyIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jk b21vQHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+IAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==