From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] network/busy_poll: TCONF if driver doesn't support busy-poll feature
Date: Thu, 13 Oct 2016 16:44:43 +0300 [thread overview]
Message-ID: <57FF8FCB.8070107@oracle.com> (raw)
In-Reply-To: <20161010151059.GD1684@rei>
Hi,
On 10/10/2016 06:11 PM, Cyril Hrubis wrote:
> Hi!
>> +ethtool --show-features $(tst_iface) | grep -q 'busy-poll.*on' || \
>> + tst_brkm TCONF "busy poll not supported by driver"
>> +
> Maybe it would be better to move all the TCONF checks into a common
> bussy_poll_lib.sh and source it in the scripts.
>
> And also we should check for ethtool command with the tst_check_cmds.
Added new shell lib with checks and applied.
Thanks,
Alexey
prev parent reply other threads:[~2016-10-13 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:48 [LTP] [PATCH] network/busy_poll: TCONF if driver doesn't support busy-poll feature Alexey Kodanev
2016-10-10 15:11 ` Cyril Hrubis
2016-10-11 11:22 ` Alexey Kodanev
2016-10-13 13:44 ` Alexey Kodanev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57FF8FCB.8070107@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.