diff for duplicates of <57FFBDE0.6000705@oracle.com> diff --git a/a/1.txt b/N1/1.txt index cd77985..b6592fd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -24,7 +24,7 @@ On Thursday 13 October 2016 09:45 PM, Julia Lawall wrote: > I'm getting a lot more reports for context mode than for patch mode, eg > for sound/pcmcia/vx/vxpocket.c. Is this normal? -This seems to be because of the ... in '*request_threaded_irq at p(...)'. +This seems to be because of the ... in '*request_threaded_irq@p(...)'. Usually I think we should have same rules for the patch and context mode. But the original code does not do that. So, I was not sure if that was intentional or not. @@ -64,7 +64,7 @@ original author of the script. >> position p; >> @@ >> ( ->> request_threaded_irq at p(irq, NULL, thread_fn, +>> request_threaded_irq@p(irq, NULL, thread_fn, >> ( >> -flags | IRQF_ONESHOT >> +IRQF_ONESHOT | ... @@ -73,7 +73,7 @@ original author of the script. >> ) >> @@ -32,20 +31,40 @@ IRQF_ONESHOT >> | ->> devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, +>> devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, >> ( >> -flags | IRQF_ONESHOT >> +IRQF_ONESHOT | ... @@ -83,8 +83,8 @@ original author of the script. >> , ...) >> ) >> ->> - at depends on patch@ ->> + at r2@ +>> -@depends on patch@ +>> +@r2@ >> expression dev; >> expression irq; >> expression thread_fn; @@ -94,16 +94,16 @@ original author of the script. >> @@ >> +flags = IRQF_ONESHOT | ...; >> +( ->> +ret = request_threaded_irq at p(irq, NULL, thread_fn, flags, ...); +>> +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); >> +| ->> +ret = devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...); +>> +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); >> +| ->> +return request_threaded_irq at p(irq, NULL, thread_fn, flags, ...); +>> +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); >> +| ->> +return devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...); +>> +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); >> +) >> + ->> + at depends on patch@ +>> +@depends on patch@ >> +expression dev; >> +expression irq; >> +expression thread_fn; @@ -112,9 +112,9 @@ original author of the script. >> +@@ >> + >> ( ->> request_threaded_irq at p(irq, NULL, thread_fn, +>> request_threaded_irq@p(irq, NULL, thread_fn, >> ( ->> @@ -69,15 +88,23 @@ devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, +>> @@ -69,15 +88,23 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, >> ) >> >> @depends on context@ @@ -122,9 +122,9 @@ original author of the script. >> +position p != {r1.p,r2.p}; >> @@ >> +( ->> *request_threaded_irq at p(...) +>> *request_threaded_irq@p(...) >> +| ->> +*devm_request_threaded_irq at p(...) +>> +*devm_request_threaded_irq@p(...) >> +) >> >> @match depends on report || org@ @@ -133,9 +133,9 @@ original author of the script. >> +position p != {r1.p,r2.p}; >> @@ >> +( ->> request_threaded_irq at p(irq, NULL, ...) +>> request_threaded_irq@p(irq, NULL, ...) >> +| ->> +devm_request_threaded_irq at p(dev, irq, NULL, ...) +>> +devm_request_threaded_irq@p(dev, irq, NULL, ...) >> +) >> >> @script:python depends on org@ diff --git a/a/content_digest b/N1/content_digest index 71e8db2..e5f369b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,15 @@ "ref\01476354490-25635-1-git-send-email-vaishali.thakkar@oracle.com\0" "ref\0alpine.DEB.2.10.1610131814180.3674@hadrien\0" - "From\0vaishali.thakkar@oracle.com (Vaishali Thakkar)\0" - "Subject\0[Cocci] [PATCH] Coccinelle: misc: Improve the script for more accurate results\0" + "From\0Vaishali Thakkar <vaishali.thakkar@oracle.com>\0" + "Subject\0Re: [PATCH] Coccinelle: misc: Improve the script for more accurate results\0" "Date\0Thu, 13 Oct 2016 22:31:20 +0530\0" - "To\0cocci@systeme.lip6.fr\0" + "To\0Julia Lawall <julia.lawall@lip6.fr>\0" + "Cc\0mmarek@suse.com" + Gilles Muller <Gilles.Muller@lip6.fr> + nicolas.palix@imag.fr + cocci@systeme.lip6.fr + linux-kernel@vger.kernel.org + " Lars-Peter Clausen <lars@metafoo.de>\0" "\00:1\0" "b\0" "\n" @@ -32,7 +38,7 @@ "> I'm getting a lot more reports for context mode than for patch mode, eg\n" "> for sound/pcmcia/vx/vxpocket.c. Is this normal?\n" "\n" - "This seems to be because of the ... in '*request_threaded_irq at p(...)'.\n" + "This seems to be because of the ... in '*request_threaded_irq@p(...)'.\n" "Usually I think we should have same rules for the patch and context mode.\n" "But the original code does not do that. So, I was not sure if that was\n" "intentional or not.\n" @@ -72,7 +78,7 @@ ">> position p;\n" ">> @@\n" ">> (\n" - ">> request_threaded_irq at p(irq, NULL, thread_fn,\n" + ">> request_threaded_irq@p(irq, NULL, thread_fn,\n" ">> (\n" ">> -flags | IRQF_ONESHOT\n" ">> +IRQF_ONESHOT | ...\n" @@ -81,7 +87,7 @@ ">> )\n" ">> @@ -32,20 +31,40 @@ IRQF_ONESHOT\n" ">> |\n" - ">> devm_request_threaded_irq at p(dev, irq, NULL, thread_fn,\n" + ">> devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,\n" ">> (\n" ">> -flags | IRQF_ONESHOT\n" ">> +IRQF_ONESHOT | ...\n" @@ -91,8 +97,8 @@ ">> , ...)\n" ">> )\n" ">>\n" - ">> - at depends on patch@\n" - ">> + at r2@\n" + ">> -@depends on patch@\n" + ">> +@r2@\n" ">> expression dev;\n" ">> expression irq;\n" ">> expression thread_fn;\n" @@ -102,16 +108,16 @@ ">> @@\n" ">> +flags = IRQF_ONESHOT | ...;\n" ">> +(\n" - ">> +ret = request_threaded_irq at p(irq, NULL, thread_fn, flags, ...);\n" + ">> +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);\n" ">> +|\n" - ">> +ret = devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...);\n" + ">> +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);\n" ">> +|\n" - ">> +return request_threaded_irq at p(irq, NULL, thread_fn, flags, ...);\n" + ">> +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);\n" ">> +|\n" - ">> +return devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...);\n" + ">> +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);\n" ">> +)\n" ">> +\n" - ">> + at depends on patch@\n" + ">> +@depends on patch@\n" ">> +expression dev;\n" ">> +expression irq;\n" ">> +expression thread_fn;\n" @@ -120,9 +126,9 @@ ">> +@@\n" ">> +\n" ">> (\n" - ">> request_threaded_irq at p(irq, NULL, thread_fn,\n" + ">> request_threaded_irq@p(irq, NULL, thread_fn,\n" ">> (\n" - ">> @@ -69,15 +88,23 @@ devm_request_threaded_irq at p(dev, irq, NULL, thread_fn,\n" + ">> @@ -69,15 +88,23 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,\n" ">> )\n" ">>\n" ">> @depends on context@\n" @@ -130,9 +136,9 @@ ">> +position p != {r1.p,r2.p};\n" ">> @@\n" ">> +(\n" - ">> *request_threaded_irq at p(...)\n" + ">> *request_threaded_irq@p(...)\n" ">> +|\n" - ">> +*devm_request_threaded_irq at p(...)\n" + ">> +*devm_request_threaded_irq@p(...)\n" ">> +)\n" ">>\n" ">> @match depends on report || org@\n" @@ -141,9 +147,9 @@ ">> +position p != {r1.p,r2.p};\n" ">> @@\n" ">> +(\n" - ">> request_threaded_irq at p(irq, NULL, ...)\n" + ">> request_threaded_irq@p(irq, NULL, ...)\n" ">> +|\n" - ">> +devm_request_threaded_irq at p(dev, irq, NULL, ...)\n" + ">> +devm_request_threaded_irq@p(dev, irq, NULL, ...)\n" ">> +)\n" ">>\n" ">> @script:python depends on org@\n" @@ -156,4 +162,4 @@ "-- \n" Vaishali -d73f8ed175f92abaa5f36feb929b9b14011b33e0ec1c0fb12204a025759a5e46 +34015170206f87fca687b678d0f0de5dd972719f05607dbd0e1e494846c630b6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.