From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org,
syzbot+b42749a851a47a0f581b@syzkaller.appspotmail.com
Subject: Re: [PATCH] block: release rq qos structures for queue without disk
Date: Mon, 14 Mar 2022 14:06:36 -0600 [thread overview]
Message-ID: <57c08222-cf24-605b-ed51-5338698e55bd@kernel.dk> (raw)
In-Reply-To: <20220314043018.177141-1-ming.lei@redhat.com>
On 3/13/22 10:30 PM, Ming Lei wrote:
> blkcg_init_queue() may add rq qos structures to request queue, previously
> blk_cleanup_queue() calls rq_qos_exit() to release them, but commit
> 8e141f9eb803 ("block: drain file system I/O on del_gendisk")
> moves rq_qos_exit() into del_gendisk(), so memory leak is caused
> because queues may not have disk, such as un-present scsi luns, nvme
> admin queue, ...
>
> Fixes the issue by adding rq_qos_exit() to blk_cleanup_queue() back.
>
> BTW, v5.18 won't need this patch any more since we move
> blkcg_init_queue()/blkcg_exit_queue() into disk allocation/release
> handler, and patches have been in for-5.18/block.
Applied, but it's a bit strange to send a 5.17 only patch against the
5.18 tree... Hand applied.
--
Jens Axboe
next prev parent reply other threads:[~2022-03-14 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 4:30 [PATCH] block: release rq qos structures for queue without disk Ming Lei
2022-03-14 6:18 ` Christoph Hellwig
2022-03-14 17:26 ` Bart Van Assche
2022-03-14 20:06 ` Jens Axboe [this message]
2022-03-14 20:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57c08222-cf24-605b-ed51-5338698e55bd@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+b42749a851a47a0f581b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.