Re: [oe] [meta-oe][PATCH] plymouth: Add the retain-splash option

["Yu, Mingli" <mingli.yu@windriver.com>]

On 2/16/22 7:26 AM, Randy MacLeod wrote:
> On 2022-02-15 04:16, Yu, Mingli wrote:
>> From: Mingli Yu<mingli.yu@windriver.com>
>>
>> Adding the "retain-splash” option to tell plymouth to keep the boot
>> splash’s contents on screen even after plymouth exits to make the
>> splash screen show more friendly on the system which boots so fast.
>>
>> Signed-off-by: Mingli Yu<mingli.yu@windriver.com>
>> ---
>>   ...lymouth-Add-the-retain-splash-option.patch | 35 +++++++++++++++++++
>>   .../recipes-core/plymouth/plymouth_0.9.5.bb   |  1 +
>>   2 files changed, 36 insertions(+)
>>   create mode 100644 meta-oe/recipes-core/plymouth/files/0001-plymouth-Add-the-retain-splash-option.patch
>>
>> diff --git a/meta-oe/recipes-core/plymouth/files/0001-plymouth-Add-the-retain-splash-option.patch b/meta-oe/recipes-core/plymouth/files/0001-plymouth-Add-the-retain-splash-option.patch
>> new file mode 100644
>> index 000000000..09876d781
>> --- /dev/null
>> +++ b/meta-oe/recipes-core/plymouth/files/0001-plymouth-Add-the-retain-splash-option.patch
>> @@ -0,0 +1,35 @@
>> +From f270f80d4c36a22a0f7b8de8fb6b1abef6f7b183 Mon Sep 17 00:00:00 2001
>> +From: Mingli Yu<mingli.yu@windriver.com>
>> +Date: Tue, 15 Feb 2022 16:23:10 +0800
>> +Subject: [PATCH] plymouth : Add the retain-splash option
>> +MIME-Version: 1.0
>> +Content-Type: text/plain; charset=UTF-8
>> +Content-Transfer-Encoding: 8bit
>> +
>> +Adding the "retain-splash” option to tell plymouth to keep the boot
>> +splash’s contents on screen even after plymouth exits to make the
>> +splash screen show more friendly on the system which boots so fast.
>> +
>> +Upstream-Status: Submitted [https://gitlab.freedesktop.org/plymouth/plymouth/-/merge_requests/157]
> 
> 
> It was rejected upstream:
> 
> "this isn't right, plymouth-quit gets used for instance when switching 
> to a getty or something that isn't graphical. Normally the display 
> manager (e.g. GDM, or whatever) would |Conflicts=plymouth-quit| so it 
> never gets run and then it would call |plymouth deactivate| and 
> |plymouth quit| on its own after its started the display"
> 
> I'm not sure what the alternative is...

I think this patch is helpful for embed system which boots up so fast 
though the plymouth upstream doesn't like it otherwise the splash screen 
show time is too short during boot as the embed system usually boots up 
in 10 seconds.

Thanks,
Grace

> 
> ../Randy
> 
>> +
>> +Signed-off-by: Mingli Yu<mingli.yu@windriver.com>
>> +---
>> + systemd-units/plymouth-quit.service.in | 2 +-
>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>> +
>> +diff --git a/systemd-units/plymouth-quit.service.in b/systemd-units/plymouth-quit.service.in
>> +index ed9f9b9..147e9ee 100644
>> +--- a/systemd-units/plymouth-quit.service.in
>> ++++ b/systemd-units/plymouth-quit.service.in
>> +@@ -3,7 +3,7 @@ Description=Terminate Plymouth Boot Screen
>> + After=rc-local.service plymouth-start.service systemd-user-sessions.service
>> +
>> + [Service]
>> +-ExecStart=-@PLYMOUTH_CLIENT_DIR@/plymouth quit
>> ++ExecStart=-@PLYMOUTH_CLIENT_DIR@/plymouth quit --retain-splash
>> + Type=oneshot
>> + RemainAfterExit=yes
>> + TimeoutSec=20
>> +--
>> +2.17.1
>> +
>> diff --git a/meta-oe/recipes-core/plymouth/plymouth_0.9.5.bb b/meta-oe/recipes-core/plymouth/plymouth_0.9.5.bb
>> index 8f9997e96..7d76ab76f 100644
>> --- a/meta-oe/recipes-core/plymouth/plymouth_0.9.5.bb
>> +++ b/meta-oe/recipes-core/plymouth/plymouth_0.9.5.bb
>> @@ -22,6 +22,7 @@ SRC_URI = " \
>>       file://0001-Make-full-path-to-systemd-tty-ask-password-agent-con.patch  \
>>       file://0001-systemd-switch-to-KillMode-mixed.patch  \
>>       file://0001-plymouth-start-service-in-add-related-kernel-paramet.patch  \
>> +file://0001-plymouth-Add-the-retain-splash-option.patch  \
>>           "
>>   
>>   SRC_URI[md5sum] = "8a25d23f3ae732af300a56fa33cacff2"
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#95315):https://lists.openembedded.org/g/openembedded-devel/message/95315
>> Mute This Topic:https://lists.openembedded.org/mt/89157208/3616765
>> Group Owner:openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub  [randy.macleod@windriver.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
> 
> -- 
> # Randy MacLeod
> # Wind River Linux
>