All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: perfbook@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: [PATCH 2/6] qqz.sty: Fix position of \goodbreak for accuracy of hyperlinks
Date: Sat, 7 Mar 2020 07:49:02 +0900	[thread overview]
Message-ID: <57ec80db-46ef-7e8a-3e79-9ec4e0e5883a@gmail.com> (raw)
In-Reply-To: <0a98646c-eb33-a27c-b974-ff38b8652a44@gmail.com>

From 440b3f3bbdd2dc212e7f277c950338f22529f532 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Fri, 6 Mar 2020 00:05:09 +0900
Subject: [PATCH 2/6] qqz.sty: Fix position of \goodbreak for accuracy of hyperlinks

Commit 9e256de3262f ("qqz.sty: Permit column/page break in front of
Quick Quiz heading") put \goodbreak after \refstepcounter{}.
This caused backward hyperlinks to QQZs at the top of pages/columns
to point the bottom of the previous pages/columns.

Fix this by placing \goodbreak in front of \refstepcounter{}.

Fixes: 9e256de3262f ("qqz.sty: Permit column/page break in front of Quick Quiz heading")
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
 qqz.sty | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qqz.sty b/qqz.sty
index 9b2aed8e..cc394160 100644
--- a/qqz.sty
+++ b/qqz.sty
@@ -33,8 +33,8 @@
 	\label{#1}
 	}
 \newcommand{\QuickQuiz}[1]{
-	\refstepcounter{quickquizctr}
-	\goodbreak\QuickQHeading{QQ}{QQA}{\thechapter.\thequickquizctr}}
+	\goodbreak\refstepcounter{quickquizctr}%
+	\QuickQHeading{QQ}{QQA}{\thechapter.\thequickquizctr}}
 \newcommand{\QuickQuizAnswer}[1]{%
 	\refstepcounter{quickquizctrE}%
 	\hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}%
-- 
2.17.1



  parent reply	other threads:[~2020-03-06 22:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 22:46 [PATCH 0/6] Improve page/column breaks in Appendix E Akira Yokosawa
2020-03-06 22:47 ` [PATCH 1/6] qqz.sty: " Akira Yokosawa
2020-03-06 22:49 ` Akira Yokosawa [this message]
2020-03-06 22:50 ` [PATCH 3/6] toolsoftrade: Use nbsp in front of single letter variable Akira Yokosawa
2020-03-06 22:51 ` [PATCH 4/6] debugging: Add opening sentence in Answer to QQZ 11.2 Akira Yokosawa
2020-03-06 22:52 ` [PATCH 5/6] defer/rcuusage: Reverse nesting of fcvref and enumerate envs Akira Yokosawa
2020-03-06 22:53 ` [PATCH 6/6] SMPdesign/partexercises: Move figure env next to first paragraph in QQA Akira Yokosawa
2020-03-07  1:29 ` [PATCH 0/6] Improve page/column breaks in Appendix E Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57ec80db-46ef-7e8a-3e79-9ec4e0e5883a@gmail.com \
    --to=akiyks@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.