From: Heiko Stuebner <heiko@sntech.de>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: maxime.ripard@free-electrons.com, wens@csie.org,
airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com,
mturquette@baylibre.com, sboyd@kernel.org,
architt@codeaurora.org, a.hajda@samsung.com,
Laurent.pinchart@ideasonboard.com, narmstrong@baylibre.com,
Jose.Abreu@synopsys.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-sunxi@googlegroups.com, p.zabel@pengutronix.de,
hjc@rock-chips.com
Subject: Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata
Date: Fri, 16 Feb 2018 08:03:59 +0100 [thread overview]
Message-ID: <5806685.TbOkgmbs60@phil> (raw)
In-Reply-To: <20180214200906.31509-6-jernej.skrabec@siol.net>
Am Mittwoch, 14. Februar 2018, 21:08:59 CET schrieb Jernej Skrabec:
> dw_hdmi shouldn't set drvdata since some drivers might need to store
> it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi
> instead to store it in drvdata. This way drivers are responsible to
> store and pass structure when needed.
>
> Idea was taken from the following commit:
> 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata")
>
> Cc: p.zabel@pengutronix.de
> Cc: narmstrong@baylibre.com
> Cc: Laurent.pinchart@ideasonboard.com
> Cc: hjc@rock-chips.com
> Cc: heiko@sntech.de
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
For the Rockchip-part
Tested-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata
Date: Fri, 16 Feb 2018 08:03:59 +0100 [thread overview]
Message-ID: <5806685.TbOkgmbs60@phil> (raw)
In-Reply-To: <20180214200906.31509-6-jernej.skrabec@siol.net>
Am Mittwoch, 14. Februar 2018, 21:08:59 CET schrieb Jernej Skrabec:
> dw_hdmi shouldn't set drvdata since some drivers might need to store
> it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi
> instead to store it in drvdata. This way drivers are responsible to
> store and pass structure when needed.
>
> Idea was taken from the following commit:
> 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata")
>
> Cc: p.zabel at pengutronix.de
> Cc: narmstrong at baylibre.com
> Cc: Laurent.pinchart at ideasonboard.com
> Cc: hjc at rock-chips.com
> Cc: heiko at sntech.de
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
For the Rockchip-part
Tested-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: mark.rutland@arm.com, Jose.Abreu@synopsys.com,
linux-sunxi@googlegroups.com, airlied@linux.ie,
mturquette@baylibre.com, narmstrong@baylibre.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
sboyd@kernel.org, wens@csie.org, robh+dt@kernel.org,
Laurent.pinchart@ideasonboard.com,
maxime.ripard@free-electrons.com, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata
Date: Fri, 16 Feb 2018 08:03:59 +0100 [thread overview]
Message-ID: <5806685.TbOkgmbs60@phil> (raw)
In-Reply-To: <20180214200906.31509-6-jernej.skrabec@siol.net>
Am Mittwoch, 14. Februar 2018, 21:08:59 CET schrieb Jernej Skrabec:
> dw_hdmi shouldn't set drvdata since some drivers might need to store
> it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi
> instead to store it in drvdata. This way drivers are responsible to
> store and pass structure when needed.
>
> Idea was taken from the following commit:
> 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata")
>
> Cc: p.zabel@pengutronix.de
> Cc: narmstrong@baylibre.com
> Cc: Laurent.pinchart@ideasonboard.com
> Cc: hjc@rock-chips.com
> Cc: heiko@sntech.de
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
For the Rockchip-part
Tested-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-16 7:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 20:08 [PATCH v5 00/12] drm/sun4i: Add A83T HDMI support Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` [PATCH v5 01/12] clk: sunxi-ng: Mask nkmp factors when setting register Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` [PATCH v5 02/12] clk: sunxi-ng: Use u64 for calculation of nkmp rate Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` [PATCH v5 03/12] drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-16 5:01 ` Archit Taneja
2018-02-16 5:01 ` Archit Taneja
2018-02-14 20:08 ` [PATCH v5 04/12] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-16 5:01 ` Archit Taneja
2018-02-16 5:01 ` Archit Taneja
2018-02-14 20:08 ` [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-14 20:08 ` Jernej Skrabec
2018-02-16 5:01 ` Archit Taneja
2018-02-16 5:01 ` Archit Taneja
2018-02-16 5:01 ` Archit Taneja
2018-02-16 7:03 ` Heiko Stuebner [this message]
2018-02-16 7:03 ` Heiko Stuebner
2018-02-16 7:03 ` Heiko Stuebner
2018-02-19 13:49 ` Philipp Zabel
2018-02-19 13:49 ` Philipp Zabel
2018-02-19 13:49 ` Philipp Zabel
2018-02-14 20:09 ` [PATCH v5 06/12] dt-bindings: display: sun4i-drm: Add A83T HDMI pipeline Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` [PATCH v5 07/12] drm/sun4i: Add has_channel_0 TCON quirk Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` [PATCH v5 08/12] drm/sun4i: Add support for A83T second TCON Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` [PATCH v5 09/12] drm/sun4i: Add support for A83T second DE2 mixer Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` [PATCH v5 10/12] drm/sun4i: Implement A83T HDMI driver Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 21:42 ` Philippe Ombredanne
2018-02-14 21:42 ` Philippe Ombredanne
2018-02-14 21:42 ` Philippe Ombredanne
2018-02-14 20:09 ` [PATCH v5 11/12] ARM: dts: sun8i: a83t: Add HDMI display pipeline Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-14 20:09 ` [PATCH v5 12/12] ARM: dts: sun8i: a83t: Enable HDMI on BananaPi M3 Jernej Skrabec
2018-02-14 20:09 ` Jernej Skrabec
2018-02-15 13:52 ` [PATCH v5 00/12] drm/sun4i: Add A83T HDMI support Maxime Ripard
2018-02-15 13:52 ` Maxime Ripard
2018-02-16 9:09 ` Maxime Ripard
2018-02-16 9:09 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5806685.TbOkgmbs60@phil \
--to=heiko@sntech.de \
--cc=Jose.Abreu@synopsys.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.