From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Heiko Stuebner To: Jernej Skrabec Cc: maxime.ripard@free-electrons.com, wens@csie.org, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@kernel.org, architt@codeaurora.org, a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, narmstrong@baylibre.com, Jose.Abreu@synopsys.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com, p.zabel@pengutronix.de, hjc@rock-chips.com Subject: Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata Date: Fri, 16 Feb 2018 08:03:59 +0100 Message-ID: <5806685.TbOkgmbs60@phil> In-Reply-To: <20180214200906.31509-6-jernej.skrabec@siol.net> References: <20180214200906.31509-1-jernej.skrabec@siol.net> <20180214200906.31509-6-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-ID: Am Mittwoch, 14. Februar 2018, 21:08:59 CET schrieb Jernej Skrabec: > dw_hdmi shouldn't set drvdata since some drivers might need to store > it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi > instead to store it in drvdata. This way drivers are responsible to > store and pass structure when needed. > > Idea was taken from the following commit: > 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata") > > Cc: p.zabel@pengutronix.de > Cc: narmstrong@baylibre.com > Cc: Laurent.pinchart@ideasonboard.com > Cc: hjc@rock-chips.com > Cc: heiko@sntech.de > Acked-by: Neil Armstrong > Signed-off-by: Jernej Skrabec For the Rockchip-part Tested-by: Heiko Stuebner Acked-by: Heiko Stuebner From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Fri, 16 Feb 2018 08:03:59 +0100 Subject: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata In-Reply-To: <20180214200906.31509-6-jernej.skrabec@siol.net> References: <20180214200906.31509-1-jernej.skrabec@siol.net> <20180214200906.31509-6-jernej.skrabec@siol.net> Message-ID: <5806685.TbOkgmbs60@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 14. Februar 2018, 21:08:59 CET schrieb Jernej Skrabec: > dw_hdmi shouldn't set drvdata since some drivers might need to store > it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi > instead to store it in drvdata. This way drivers are responsible to > store and pass structure when needed. > > Idea was taken from the following commit: > 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata") > > Cc: p.zabel at pengutronix.de > Cc: narmstrong at baylibre.com > Cc: Laurent.pinchart at ideasonboard.com > Cc: hjc at rock-chips.com > Cc: heiko at sntech.de > Acked-by: Neil Armstrong > Signed-off-by: Jernej Skrabec For the Rockchip-part Tested-by: Heiko Stuebner Acked-by: Heiko Stuebner From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata Date: Fri, 16 Feb 2018 08:03:59 +0100 Message-ID: <5806685.TbOkgmbs60@phil> References: <20180214200906.31509-1-jernej.skrabec@siol.net> <20180214200906.31509-6-jernej.skrabec@siol.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180214200906.31509-6-jernej.skrabec@siol.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jernej Skrabec Cc: mark.rutland@arm.com, Jose.Abreu@synopsys.com, linux-sunxi@googlegroups.com, airlied@linux.ie, mturquette@baylibre.com, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sboyd@kernel.org, wens@csie.org, robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com, maxime.ripard@free-electrons.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org QW0gTWl0dHdvY2gsIDE0LiBGZWJydWFyIDIwMTgsIDIxOjA4OjU5IENFVCBzY2hyaWViIEplcm5l aiBTa3JhYmVjOgo+IGR3X2hkbWkgc2hvdWxkbid0IHNldCBkcnZkYXRhIHNpbmNlIHNvbWUgZHJp dmVycyBtaWdodCBuZWVkIHRvIHN0b3JlCj4gaXQncyBvd24gZGF0YSB0aGVyZS4gUmV3b3JrIGR3 X2hkbWkgaW4gYSB3YXkgdG8gcmV0dXJuIHN0cnVjdCBkd19oZG1pCj4gaW5zdGVhZCB0byBzdG9y ZSBpdCBpbiBkcnZkYXRhLiBUaGlzIHdheSBkcml2ZXJzIGFyZSByZXNwb25zaWJsZSB0bwo+IHN0 b3JlIGFuZCBwYXNzIHN0cnVjdHVyZSB3aGVuIG5lZWRlZC4KPiAKPiBJZGVhIHdhcyB0YWtlbiBm cm9tIHRoZSBmb2xsb3dpbmcgY29tbWl0Ogo+IDgyNDJlY2JkNTk3ZCAoImRybS9icmlkZ2Uvc3lu b3BzeXM6IHN0b3AgY2xvYmJlcmluZyBkcnZkYXRhIikKPiAKPiBDYzogcC56YWJlbEBwZW5ndXRy b25peC5kZQo+IENjOiBuYXJtc3Ryb25nQGJheWxpYnJlLmNvbQo+IENjOiBMYXVyZW50LnBpbmNo YXJ0QGlkZWFzb25ib2FyZC5jb20KPiBDYzogaGpjQHJvY2stY2hpcHMuY29tCj4gQ2M6IGhlaWtv QHNudGVjaC5kZQo+IEFja2VkLWJ5OiBOZWlsIEFybXN0cm9uZyA8bmFybXN0cm9uZ0BiYXlsaWJy ZS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmVybmVqIFNrcmFiZWMgPGplcm5lai5za3JhYmVjQHNp b2wubmV0PgoKRm9yIHRoZSBSb2NrY2hpcC1wYXJ0ClRlc3RlZC1ieTogSGVpa28gU3R1ZWJuZXIg PGhlaWtvQHNudGVjaC5kZT4KQWNrZWQtYnk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2gu ZGU+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=