From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Andrei Gherzan <andrei@gherzan.ro>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [V2 PATCH 5/6] task-core-boot: Add busybox-hwclock if MACHINE_FEATURES contains rtc
Date: Mon, 03 Sep 2012 09:03:30 +0100 [thread overview]
Message-ID: <5808938.Nh0F33ee0J@helios> (raw)
In-Reply-To: <2c0055c43eae1489aee3e5e3fa2b8481d10fe0ce.1345155936.git.andrei@gherzan.ro>
On Friday 17 August 2012 01:28:51 Andrei Gherzan wrote:
> For machines with no hardware clock it makes no sense to have this
> init stript. Moreover, we avoid a boot error in this way.
>
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
> meta/recipes-core/tasks/task-core-boot.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/tasks/task-core-boot.bb
> b/meta/recipes-core/tasks/task-core-boot.bb index 6487436..2947509 100644
> --- a/meta/recipes-core/tasks/task-core-boot.bb
> +++ b/meta/recipes-core/tasks/task-core-boot.bb
> @@ -34,6 +34,7 @@ RDEPENDS_task-core-boot = "\
> base-files \
> base-passwd \
> busybox \
> + ${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)}
> \ ${VIRTUAL-RUNTIME_initscripts} \
> ${@base_contains("MACHINE_FEATURES", "keyboard",
> "${VIRTUAL-RUNTIME_keymaps}", "", d)} \ modutils-initscripts \
Why did this get added to task-core-boot? This is meant only to contain items
that are essential for booting; I'm not sure that support for the rtc
qualifies.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-09-03 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 22:28 [V2 PATCH 0/6] Don't have hwclock init scripts for machines without rtc Andrei Gherzan
2012-08-16 22:28 ` [V2 PATCH 1/6] utils.py: Modify and rename distro_features_backfill python function Andrei Gherzan
2012-08-16 22:28 ` [V2 PATCH 2/6] bitbake.conf: Use the new form of features_backfill function Andrei Gherzan
2012-08-16 22:28 ` [V2 PATCH 3/6] bitbake.conf: Add MACHINE_FEATURES_BACKFILL and append to MACHINE_FEATURES Andrei Gherzan
2012-08-16 22:28 ` [V2 PATCH 4/6] bitbake.conf: Add rtc to MACHINE_FEATURES_BACKFILL Andrei Gherzan
2012-08-16 22:28 ` [V2 PATCH 5/6] task-core-boot: Add busybox-hwclock if MACHINE_FEATURES contains rtc Andrei Gherzan
2012-09-03 8:03 ` Paul Eggleton [this message]
2012-09-03 11:30 ` Andrei Gherzan
2012-08-16 22:28 ` [V2 PATCH 6/6] busybox: Package hwclock.sh initscript separately Andrei Gherzan
2012-08-17 22:23 ` [V2 PATCH 0/6] Don't have hwclock init scripts for machines without rtc Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5808938.Nh0F33ee0J@helios \
--to=paul.eggleton@linux.intel.com \
--cc=andrei@gherzan.ro \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.