All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] travis-ci: Drop 'TEST_CMD'
Date: Fri, 21 Oct 2016 09:54:56 +0200	[thread overview]
Message-ID: <5809C9D0.5000404@denx.de> (raw)
In-Reply-To: <1476991566-2989-8-git-send-email-trini@konsulko.com>

Hello Tom,

Am 20.10.2016 um 21:26 schrieb Tom Rini:
> We don't need to use TEST_CMD in order to run tests.  We need a BUILDMAN
> and TOOLCHAIN variable to avoid having to duplicate logic or write some
> wrapper function.  But this makes the tests harder as we add more
> complex examples.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>   .travis.yml | 26 ++++++++++----------------
>   1 file changed, 10 insertions(+), 16 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko

>
> diff --git a/.travis.yml b/.travis.yml
> index 8ebcfaf996ab..25b0023d631b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -57,10 +57,6 @@ before_script:
>     - if [[ "${TOOLCHAIN}" == *xtensa* ]]; then ./tools/buildman/buildman --fetch-arch xtensa ; fi
>
>   script:
> - # the execution sequence for each test
> - - if [[ "${TEST_CMD}" != "" ]]; then
> -     ${TEST_CMD};
> -   fi
>    # Exit code 129 means warnings only.
>    - if [[ "${BUILDMAN}" != "" ]]; then
>        set +e;
> @@ -154,24 +150,22 @@ matrix:
>
>       # QA jobs for code analytics
>       # static code analysis with cppcheck (we can add --enable=all later)
> -    - env:
> -        - TEST_CMD="cppcheck --force --quiet --inline-suppr ."
> +    - script:
> +        - cppcheck --force --quiet --inline-suppr .
>       # search for TODO within source tree
> -    - env:
> -        - TEST_CMD="grep -r TODO ."
> +    - script:
> +        - grep -r TODO .
>       # search for FIXME within source tree
> -    - env:
> -        - TEST_CMD="grep -r FIXME ."
> +    - script:
> +        - grep -r FIXME .
>       # search for HACK within source tree and ignore HACKKIT board
> -    - env:
> -        - TEST_CMD="grep -r HACK . | grep -v HACKKIT"
>         script:
>           - grep -r HACK . | grep -v HACKKIT
>       # some statistics about the code base
> -    - env:
> -        - TEST_CMD="sloccount ."
> +    - script:
> +        - sloccount .
>       # test/py
> -    - env:
> -        - TEST_CMD="./test/py/test.py --bd sandbox --build"
> +    - script:
> +        - ./test/py/test.py --bd sandbox --build
>
>   # TODO make it perfect ;-r
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2016-10-21  7:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 19:25 [U-Boot] [PATCH 0/8] Various travis-ci improvements Tom Rini
2016-10-20 19:25 ` [U-Boot] [PATCH 1/8] test/py: ensure a log section exists for skipped tests Tom Rini
2016-10-20 19:26 ` [U-Boot] [PATCH 2/8] travis-ci: Switch to Ubuntu 14.04 'Trusty Tahr' Tom Rini
2016-10-21  7:27   ` Heiko Schocher
2016-10-24 15:23   ` Tom Rini
2016-10-20 19:26 ` [U-Boot] [PATCH 3/8] travis-ci: Use a git URI for dtc.git Tom Rini
2016-10-21  7:32   ` Heiko Schocher
2016-10-24 15:23   ` Tom Rini
2016-10-20 19:26 ` [U-Boot] [PATCH 4/8] travis-ci: Do not make buildman warnings fatal Tom Rini
2016-10-21  7:39   ` Heiko Schocher
2016-10-21 11:19     ` Tom Rini
2016-10-24 15:23   ` Tom Rini
2016-10-20 19:26 ` [U-Boot] [PATCH 5/8] travis-ci: Update toolchain and buildman usage Tom Rini
2016-10-21  7:40   ` Heiko Schocher
2016-10-24 15:23   ` Tom Rini
2016-10-20 19:26 ` [U-Boot] [PATCH 6/8] travis-ci: Add more architectures Tom Rini
2016-10-21  7:41   ` Heiko Schocher
2016-10-24 15:23   ` Tom Rini
2016-10-20 19:26 ` [U-Boot] [PATCH 7/8] travis-ci: Drop 'TEST_CMD' Tom Rini
2016-10-21  7:54   ` Heiko Schocher [this message]
2016-10-24 15:23   ` Tom Rini
2016-10-20 19:26 ` [U-Boot] [PATCH 8/8] travis-ci: Add test.py for various qemu platforms Tom Rini
2016-10-20 19:40   ` [U-Boot] [PATCH v2 " Tom Rini
2016-10-21 18:24     ` Stephen Warren
2016-10-22 12:56       ` Tom Rini
2016-10-24 22:21         ` Stephen Warren
2016-10-24 22:46           ` Tom Rini
2016-10-24 15:23     ` Tom Rini
2016-10-21  9:22   ` [U-Boot] [PATCH " Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5809C9D0.5000404@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.