From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754989AbcJUKsr (ORCPT ); Fri, 21 Oct 2016 06:48:47 -0400 Received: from mga07.intel.com ([134.134.136.100]:56031 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752203AbcJUKsq (ORCPT ); Fri, 21 Oct 2016 06:48:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,375,1473145200"; d="scan'208";a="892432887" Subject: Re: [PATCH v2 1/1] usb: xhci: clean up error_bitmask usage To: Lu Baolu References: <1477019650-3988-1-git-send-email-baolu.lu@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Mathias Nyman Message-ID: <5809F2A0.7090800@linux.intel.com> Date: Fri, 21 Oct 2016 13:49:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1477019650-3988-1-git-send-email-baolu.lu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.10.2016 06:14, Lu Baolu wrote: > In xhci_handle_event(), when errors are detected, driver always sets > a bit in error_bitmask (one member of the xhci private driver data). > That means users have to retrieve and decode the value of error_bitmask > in xhci private driver data if they want to know whether those erros > ever happened in xhci_handle_event(). Otherwise, those errors are just > ignored silently. > > This patch cleans up this by replacing the setting of error_bitmask > with the kernel print functions, so that users can easily check and > report the errors happened in xhci_handle_event(). > > Signed-off-by: Lu Baolu > --- > Changelog: > V2: > - Remove "return" for failed port status event; > - Refine checking return value of handle_tx_event(); > - Print the right TRB type value in debug message. > Thanks, added -Mathias