From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934741AbcJUV3f (ORCPT ); Fri, 21 Oct 2016 17:29:35 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:32959 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933451AbcJUV3e (ORCPT ); Fri, 21 Oct 2016 17:29:34 -0400 Subject: Re: [PATCH v3 2/2] initramfs: Allow again choice of the embedded initram compression algorithm To: Andrew Morton , klondike References: <54239E69.4050803@klondike.es> <57EAC8CC.3070602@klondike.es> <57EAD3BC.9050802@klondike.es> <57EAD77B.7090607@klondike.es> <20161021142154.211eb0ae3784e055429a92e3@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, P J P , Paul Bolle From: "Francisco Blas Izquierdo Riera (klondike)" X-Enigmail-Draft-Status: N1110 Message-ID: <580A88B3.9030101@klondike.es> Date: Fri, 21 Oct 2016 23:29:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20161021142154.211eb0ae3784e055429a92e3@linux-foundation.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c0EJva3FrHLoQnWxNFoJkcnpHmxOhe2Jp" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c0EJva3FrHLoQnWxNFoJkcnpHmxOhe2Jp Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hello Andrew! El 21/10/16 a las 23:21, Andrew Morton escribi=F3: > On Tue, 27 Sep 2016 22:32:59 +0200 klondike wr= ote: > >> Choosing the appropriate compression option when using an embeded init= ramfs >> can result in significant size differences in the resulting data. >> >> This is caused by avoiding double compression of the initramfs content= s. >> For example on my tests, choosing CONFIG_INITRAMFS_COMPRESSION_NONE wh= en >> compressing the kernel using XZ) results in up to 500KiB differences (= 9MiB to >> 8.5MiB) in the kernel size as the dictionary will not get polluted wi= th >> uncomprensible data and may reuse kernel data too. >> >> Despite embedding an uncompressed initramfs, a user may want to allow = for a >> compressed extra initramfs to be passed using the rd system, for examp= le to >> boot a recovery system. Commit 9ba4bcb645898d562498ea66a0df958ef0e7a68= c >> ("initramfs: read CONFIG_RD_ variables for initramfs compression") bro= ke >> that behavior by making the choice based on CONFIG_RD_* instead of add= ing >> CONFIG_INITRAMFS_COMPRESSION_LZ4. Saddly, CONFIG_RD_* is also used to >> choose the supported RD compression algorithms by the kernel and a use= r may >> want to suppport more than one. >> >> This patch also reverses 3e4e0f0a8756dade3023d1f47d50fbced7749788 >> ("initramfs: remove "compression mode" choice") restoring back the >> "compression mode" choice and includes the CONFIG_INITRAMFS_COMPRESSIO= N_LZ4 >> option which was never added. >> >> As a result the following options are added or readed affecting the em= bedded >> initramfs compression: >> INITRAMFS_COMPRESSION_NONE Do no compression >> INITRAMFS_COMPRESSION_GZIP Compress using gzip >> INITRAMFS_COMPRESSION_BZIP2 Compress using bzip2 >> INITRAMFS_COMPRESSION_LZMA Compress using lzma >> INITRAMFS_COMPRESSION_XZ Compress using xz >> INITRAMFS_COMPRESSION_LZO Compress using lzo >> INITRAMFS_COMPRESSION_LZ4 Compress using lz4 >> >> These depend on the corresponding CONFIG_RD_* option being set (except= NONE >> which has no dependencies). > As you sent them, these patches would be merged with > > From: klondike > Signed-off-by: Francisco Blas Izquierdo Riera (klondike) > > Which is strange. Different email addresses and "klondike" isn't a > real name. Ugh that was my mistake, the e-mail should have been sent from my klondike@klondike.es address. I guess at some point during sending I messed it up. Sorry for that. > So I'll rewrite the From: address to match the SOB address. That's perfect, thanks :) > You can do this yourself by including an explicit From: line as the > first line of the changelog text. Thanks! I'm still trying to learn how the kernel patching process works so the tip is very appreciated.I'll be careful and use the From line next time :) Sincerely, Klondike --c0EJva3FrHLoQnWxNFoJkcnpHmxOhe2Jp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJYCoi5AAoJEPS90u/o/3j5lIMQAJ7BFwxbE2YhVlNPKvxx4Euq SsxLaoz3+Mb1pxAjvcqtmoitfltuqqiCfdcOF0u0X6XwDtJ+FyaWjylWuc8qU5Xs SHWfUsSQxnidyxefFrjqUpCEI3+5ESFKr6Bml29ceuAoXI+v3okei2KhCwpujF+V oGNC4XGaYXdUiG9mxCORnBi/ov+tOQPK7Szcr1jR0EMyfvZkFEwz6FxYXkWu+se/ ehwVTBSRdmi2B4UQY802EC+CN76duxP+m40d5ncJnrRpx5A+8d7duHAs38N2tErr XNvbdaPtdRd5Wl7T9PRE5M2eoRm1r+Aim8ZkU/tEDh00wzrgLBpL6gDRXwdVAn8D 4jUQDHWvKmklnhiTRHcmsRuuD5PYxoAEjvVaMexAGYPPf+twepEtJdxgjZ46z7D7 iMoGWVDUXuOywcIH7xJpWNzX0gVxVKMik+yKzzSXC956c9nLDVwd2/S6Vd2doYro lV831nR0GRxbr5OzDsfzS8C8ePxZXHMWaoBWbqQlKLpdLBvQTh4ZXd3FR34rChyM K/3TZfmvgZmnQCQN7No5lttWYido8/pxbJxQ7WLn7b/uZy+eZQCgPqVA+V0lhrgu WZAcNG12x4lQYLEfPw9ZV9t7nwL3qD1VmAXIQAUdA7DfEl6IVf/YVPdnrZmsJLUf tyfr7d70sqGYFoDNVpw1 =Fifu -----END PGP SIGNATURE----- --c0EJva3FrHLoQnWxNFoJkcnpHmxOhe2Jp--