Re: [PATCH] drm/amdgpu: release parent fence reference

From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: Grazvydas Ignotas
	<notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: release parent fence reference
Date: Mon, 24 Oct 2016 10:25:02 +0800	[thread overview]
Message-ID: <580D70FE.4010404@amd.com> (raw)
In-Reply-To: <1477247507-11378-4-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>


On 2016年10月24日 02:31, Grazvydas Ignotas wrote:
> It's done in amd_sched_hw_job_reset(), but not in normal job processing.
> Leak reported by CONFIG_SLUB_DEBUG.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
>   CONFIG_SLUB_DEBUG reports more leaks related to ioctls,
>   but I was unable to track them down...
>
>   drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> index 910b8d5..cfb686e 100644
> --- a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> @@ -522,6 +522,8 @@ static void amd_sched_process_job(struct fence *f, struct fence_cb *cb)
>   
>   	trace_amd_sched_process_job(s_fence);
>   	fence_put(&s_fence->finished);
> +	fence_put(s_fence->parent);
If I remember correctly, parent was put in sched fence release.

Regards,
David Zhou
> +	s_fence->parent = NULL;
>   	wake_up_interruptible(&sched->wake_up_worker);
>   }
>   

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx