From mboxrd@z Thu Jan 1 00:00:00 1970 From: xinhui Subject: Re: [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check Date: Mon, 24 Oct 2016 10:46:54 +0800 Message-ID: <580D761E.5000508@linux.vnet.ibm.com> References: <1476998874-2089-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> <1476998874-2089-10-git-send-email-xinhui.pan@linux.vnet.ibm.com> <063D6719AE5E284EB5DD2968C1650D6DB0207B44@AcuExch.aculab.com> <20161021183951.GA29131@potion> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161021183951.GA29131@potion> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Archive: List-Post: To: "rkrcmar@redhat.com" , David Laight Cc: "kernellwp@gmail.com" , "linux-s390@vger.kernel.org" , "jgross@suse.com" , "kvm@vger.kernel.org" , "peterz@infradead.org" , "xen-devel-request@lists.xenproject.org" , "boqun.feng@gmail.com" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "mingo@redhat.com" , "paulus@samba.org" , "pbonzini@redhat.com" , "paulmck@linux.vnet.ibm.com" , "linuxppc-dev@lists.ozlabs.org" List-ID: CgpPbiAyMDE25bm0MTDmnIgyMuaXpSAwMjozOSwgcmtyY21hckByZWRoYXQuY29tIHdyb3RlOgo+ IDIwMTYtMTAtMjEgMTE6MjcrMDAwMCwgRGF2aWQgTGFpZ2h0Ogo+PiBGcm9tOiBQYW4gWGluaHVp Cj4+PiBTZW50OiAyMCBPY3RvYmVyIDIwMTYgMjI6MjgKPj4+IENvbW1pdCAoIng4Niwga3ZtOiBz dXBwb3J0IHZjcHUgcHJlZW1wdGVkIGNoZWNrIikgYWRkIG9uZSBmaWVsZCAiX191OAo+Pj4gcHJl ZW1wdGVkIiBpbnRvIHN0cnVjdCBrdm1fc3RlYWxfdGltZS4gVGhpcyBmaWVsZCB0ZWxscyBpZiBv bmUgdmNwdSBpcwo+Pj4gcnVubmluZyBvciBub3QuCj4+Pgo+Pj4gSXQgaXMgemVybyBpZiAxKSBz b21lIG9sZCBLVk0gZGVvcyBub3Qgc3VwcG9ydCB0aGlzIGZpbGVkLiAyKSB0aGUgdmNwdSBpcwo+ Pj4gcHJlZW1wdGVkLiBPdGhlciB2YWx1ZXMgbWVhbnMgdGhlIHZjcHUgaGFzIGJlZW4gcHJlZW1w dGVkLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFBhbiBYaW5odWkgPHhpbmh1aS5wYW5AbGludXgu dm5ldC5pYm0uY29tPgo+Pj4gLS0tCj4+PiAgIERvY3VtZW50YXRpb24vdmlydHVhbC9rdm0vbXNy LnR4dCB8IDggKysrKysrKy0KPj4+ICAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL3ZpcnR1YWwv a3ZtL21zci50eHQgYi9Eb2N1bWVudGF0aW9uL3ZpcnR1YWwva3ZtL21zci50eHQKPj4+IGluZGV4 IDJhNzFjOGYuLjMzNzZmMTMgMTAwNjQ0Cj4+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL3ZpcnR1YWwv a3ZtL21zci50eHQKPj4+ICsrKyBiL0RvY3VtZW50YXRpb24vdmlydHVhbC9rdm0vbXNyLnR4dAo+ Pj4gQEAgLTIwOCw3ICsyMDgsOCBAQCBNU1JfS1ZNX1NURUFMX1RJTUU6IDB4NGI1NjRkMDMKPj4+ ICAgCQlfX3U2NCBzdGVhbDsKPj4+ICAgCQlfX3UzMiB2ZXJzaW9uOwo+Pj4gICAJCV9fdTMyIGZs YWdzOwo+Pj4gLQkJX191MzIgcGFkWzEyXTsKPj4+ICsJCV9fdTggIHByZWVtcHRlZDsKPj4+ICsJ CV9fdTMyIHBhZFsxMV07Cj4+PiAgIAl9Cj4+Cj4+IEkgdGhpbmsgSSdkIGJlIGV4cGxpY2l0IGFi b3V0IHRoZSAzIHBhZCBieXRlcyB5b3UndmUgbGVmdC4KPgo+IFNlY29uZGVkLgo+Cj4gV2l0aCB0 aGF0IGNoYW5nZSBhcmUgYWxsIEtWTSBiaXRzCj4KbGlrZSBiZWxvdz8KX191OCBwcmVlbXB0ZWQ7 Cl9fdTgga3ZtX3BhZFszXTsKCgo+IEFja2VkLWJ5OiBSYWRpbSBLcsSNbcOhxZkgPHJrcmNtYXJA cmVkaGF0LmNvbT4KPgp0aGFua3MhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25A bGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24u b3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3t2LKV4R6jzDvWm for ; Mon, 24 Oct 2016 13:47:10 +1100 (AEDT) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9O2i432136748 for ; Sun, 23 Oct 2016 22:47:08 -0400 Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142]) by mx0a-001b2d01.pphosted.com with ESMTP id 2695ej7rdp-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sun, 23 Oct 2016 22:47:08 -0400 Received: from localhost by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Oct 2016 12:47:06 +1000 Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 6BC48357805A for ; Mon, 24 Oct 2016 13:47:02 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9O2l2Fk16646306 for ; Mon, 24 Oct 2016 13:47:02 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9O2l10d028081 for ; Mon, 24 Oct 2016 13:47:02 +1100 Date: Mon, 24 Oct 2016 10:46:54 +0800 From: xinhui MIME-Version: 1.0 To: "rkrcmar@redhat.com" , David Laight CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "virtualization@lists.linux-foundation.org" , "linux-s390@vger.kernel.org" , "xen-devel-request@lists.xenproject.org" , "kvm@vger.kernel.org" , "kernellwp@gmail.com" , "jgross@suse.com" , "peterz@infradead.org" , "will.deacon@arm.com" , "borntraeger@de.ibm.com" , "mingo@redhat.com" , "paulus@samba.org" , "pbonzini@redhat.com" , "paulmck@linux.vnet.ibm.com" , "boqun.feng@gmail.com" Subject: Re: [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check References: <1476998874-2089-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> <1476998874-2089-10-git-send-email-xinhui.pan@linux.vnet.ibm.com> <063D6719AE5E284EB5DD2968C1650D6DB0207B44@AcuExch.aculab.com> <20161021183951.GA29131@potion> In-Reply-To: <20161021183951.GA29131@potion> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <580D761E.5000508@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2016年10月22日 02:39, rkrcmar@redhat.com wrote: > 2016-10-21 11:27+0000, David Laight: >> From: Pan Xinhui >>> Sent: 20 October 2016 22:28 >>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >>> preempted" into struct kvm_steal_time. This field tells if one vcpu is >>> running or not. >>> >>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >>> preempted. Other values means the vcpu has been preempted. >>> >>> Signed-off-by: Pan Xinhui >>> --- >>> Documentation/virtual/kvm/msr.txt | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >>> index 2a71c8f..3376f13 100644 >>> --- a/Documentation/virtual/kvm/msr.txt >>> +++ b/Documentation/virtual/kvm/msr.txt >>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >>> __u64 steal; >>> __u32 version; >>> __u32 flags; >>> - __u32 pad[12]; >>> + __u8 preempted; >>> + __u32 pad[11]; >>> } >> >> I think I'd be explicit about the 3 pad bytes you've left. > > Seconded. > > With that change are all KVM bits > like below? __u8 preempted; __u8 kvm_pad[3]; > Acked-by: Radim Krčmář > thanks!