From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH 2/5] key: Make key/keychain revocation optional when freeing
Date: Mon, 24 Oct 2016 15:45:28 -0500 [thread overview]
Message-ID: <580E72E8.9080303@gmail.com> (raw)
In-Reply-To: <alpine.OSX.2.20.1610241325170.1909@mjmartin-mac01.wa.intel.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
Hi Mat,
>> +1. Although we do have precedent for this in l_string_free, but that
>> is mostly how GLib API was done.
>
> Ok, I'll go with l_key_revoke_and_free(). It was l_string_free that sent
> me in the original add-a-flag direction, but that's also a function that
> has been a source of confusion.
>
Yeah, blame GLib for that. The point of ell was to make it easy to port
GLib based projects, so I'm not sure if changing l_string_free is better
or worse.
I would personally vote for l_key_free and l_key_free_norevoke.
Regards,
-Denis
next prev parent reply other threads:[~2016-10-24 20:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 18:44 [PATCH 1/5] util: Remove semicolons in single-statement macros Mat Martineau
2016-10-24 18:44 ` [PATCH 2/5] key: Make key/keychain revocation optional when freeing Mat Martineau
2016-10-24 18:47 ` Mat Martineau
2016-10-24 18:55 ` Marcel Holtmann
2016-10-24 19:07 ` Denis Kenzior
2016-10-24 20:34 ` Mat Martineau
2016-10-24 20:39 ` Marcel Holtmann
2016-10-24 20:45 ` Denis Kenzior [this message]
2016-10-24 18:44 ` [PATCH 3/5] unit: Update for new l_key_free/l_keyring_free revoke parameter Mat Martineau
2016-10-24 18:44 ` [PATCH 4/5] tls: Validate cert chain using l_keyring Mat Martineau
2016-10-24 18:44 ` [PATCH 5/5] unit: Fix memory leak in trust chain test Mat Martineau
2016-10-24 19:06 ` [PATCH 1/5] util: Remove semicolons in single-statement macros Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580E72E8.9080303@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.