All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@intel.com>
To: Babu Moger <babu.moger@oracle.com>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 RESEND] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers
Date: Tue, 25 Oct 2016 09:51:10 +0300	[thread overview]
Message-ID: <580F00DE.9030508@intel.com> (raw)
In-Reply-To: <80d710fc-a30f-b661-7ca3-f3df9d020c30@oracle.com>

On 24.10.2016 17:52, Babu Moger wrote:
>
> On 10/24/2016 5:54 AM, Yoshihiro Shimoda wrote:
>> Hi,
>>
>>> From: Mathias Nyman
>>> Sent: Monday, October 24, 2016 6:58 PM
>>>
>>> On 22.10.2016 01:25, Babu Moger wrote:
>>>> Never seen XHCI auto handoff working on TI and RENESAS cards.
>>>> Eventually, we force handoff. This code forces the handoff
>>>> unconditionally. It saves 5 seconds boot time for each card.
>>>>
>>>> Signed-off-by: Babu Moger <babu.moger@oracle.com>
>>> Do the Renesas and TI controllers still advertise the extended capability
>>> for the handoff? (XHCI_EXT_CAPS_LEGACY)
> I don't see this capability.  Here is lspci output.
>

It's not a PCI capability, it's a xhci Extended Capability.

If the capability is supported, and handoff fail, then quirk_usb_handoff_xhci() will print
"xHCI BIOS handoff failed (BIOS bug ?)"

Further on in the same function we wait for the "controller not ready" bit in the status
register to clear. If that times it prints out:

"xHCI HW not ready after 5 sec (HC bug?) status"

Do you see any of these two messages in the log?

-Mathias

  reply	other threads:[~2016-10-25  6:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 22:25 [PATCH v2 RESEND] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers Babu Moger
2016-10-24  9:57 ` Mathias Nyman
2016-10-24 10:54   ` Yoshihiro Shimoda
2016-10-24 14:52     ` Babu Moger
2016-10-25  6:51       ` Mathias Nyman [this message]
2016-10-25 13:10         ` Babu Moger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=580F00DE.9030508@intel.com \
    --to=mathias.nyman@intel.com \
    --cc=babu.moger@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.