From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:39628 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbeDYNcL (ORCPT ); Wed, 25 Apr 2018 09:32:11 -0400 From: Laurent Pinchart To: Vaishali Thakkar Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: rcar-du: Use drm_dev_put Date: Wed, 25 Apr 2018 16:32:25 +0300 Message-ID: <5811471.PjpYk9OX8O@avalon> In-Reply-To: <20180425121036.28965-1-vthakkar1994@gmail.com> References: <20180425121036.28965-1-vthakkar1994@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Vaishali, Thank you for the patch. On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote: > As specified in drm_drv.c, drm_dev_unref is a compatibility alias > for drm_dev_put and shouldn't be used in new code. So, use > drm_dev_put instead. This looks good to me. However, how about taking it one step further and mass- patching all drivers to use drm_dev_put() ? We could then remove drm_dev_unref() completely. > Signed-off-by: Vaishali Thakkar > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 05745e86d73e..418a80e6b2f4 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev) > drm_kms_helper_poll_fini(ddev); > drm_mode_config_cleanup(ddev); > > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return 0; > } -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: Use drm_dev_put Date: Wed, 25 Apr 2018 16:32:25 +0300 Message-ID: <5811471.PjpYk9OX8O@avalon> References: <20180425121036.28965-1-vthakkar1994@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89CC96E5C9 for ; Wed, 25 Apr 2018 13:32:11 +0000 (UTC) In-Reply-To: <20180425121036.28965-1-vthakkar1994@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vaishali Thakkar Cc: airlied@linux.ie, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVmFpc2hhbGksCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFdlZG5lc2RheSwgMjUg QXByaWwgMjAxOCAxNToxMDozNiBFRVNUIFZhaXNoYWxpIFRoYWtrYXIgd3JvdGU6Cj4gQXMgc3Bl Y2lmaWVkIGluIGRybV9kcnYuYywgZHJtX2Rldl91bnJlZiBpcyBhIGNvbXBhdGliaWxpdHkgYWxp YXMKPiBmb3IgZHJtX2Rldl9wdXQgYW5kIHNob3VsZG4ndCBiZSB1c2VkIGluIG5ldyBjb2RlLiBT bywgdXNlCj4gZHJtX2Rldl9wdXQgaW5zdGVhZC4KClRoaXMgbG9va3MgZ29vZCB0byBtZS4gSG93 ZXZlciwgaG93IGFib3V0IHRha2luZyBpdCBvbmUgc3RlcCBmdXJ0aGVyIGFuZCBtYXNzLQpwYXRj aGluZyBhbGwgZHJpdmVycyB0byB1c2UgZHJtX2Rldl9wdXQoKSA/IFdlIGNvdWxkIHRoZW4gcmVt b3ZlIApkcm1fZGV2X3VucmVmKCkgY29tcGxldGVseS4KCj4gU2lnbmVkLW9mZi1ieTogVmFpc2hh bGkgVGhha2thciA8dnRoYWtrYXIxOTk0QGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfZHJ2LmMgaW5kZXggMDU3NDVlODZkNzNlLi40MThhODBlNmIyZjQKPiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IEBAIC0zNzgsNyArMzc4LDcgQEAgc3RhdGlj IGludCByY2FyX2R1X3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJZHJt X2ttc19oZWxwZXJfcG9sbF9maW5pKGRkZXYpOwo+ICAJZHJtX21vZGVfY29uZmlnX2NsZWFudXAo ZGRldik7Cj4gCj4gLQlkcm1fZGV2X3VucmVmKGRkZXYpOwo+ICsJZHJtX2Rldl9wdXQoZGRldik7 Cj4gCj4gIAlyZXR1cm4gMDsKPiAgfQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=