From: Jike Song <jike.song@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: alex.williamson@redhat.com, guangrong.xiao@linux.intel.com,
kwankhede@nvidia.com, cjia@nvidia.com, kevin.tian@intel.com,
kvm@vger.kernel.org
Subject: Re: [v2 3/5] KVM: move kvm_{get|put}_kvm to kvm_host.h
Date: Mon, 31 Oct 2016 09:40:26 +0800 [thread overview]
Message-ID: <5816A10A.7010203@intel.com> (raw)
In-Reply-To: <dee37614-1c7e-389c-ec53-77cf0baee80f@redhat.com>
On 10/30/2016 04:53 PM, Paolo Bonzini wrote:
> On 29/10/2016 22:05, Jike Song wrote:
>> So that external users like vfio can call them without introducing
>> symbol-level dependency. A destroy() method is introduced to the kvm
>> structure so that we don't have to also expose kvm_destroy_vm.
>
> VFIO does not need kvm_put_kvm, so kvm_destroy_vm need not be exported
> (or kvm_put_kvm can remain non-inline).
Yes, good point. Will keep kvm_put_kvm.
--
Thanks,
Jike
next prev parent reply other threads:[~2016-10-31 1:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 20:05 [v2 0/5] plumb kvm/vfio to allow getting kvm from vfio_group Jike Song
2016-10-29 20:05 ` [v2 1/5] vfio: Rearrange functions to get vfio_group from dev Jike Song
2016-10-29 20:05 ` [v2 2/5] vfio: export functions to get vfio_group from device and put it Jike Song
2016-10-29 20:05 ` [v2 3/5] KVM: move kvm_{get|put}_kvm to kvm_host.h Jike Song
2016-10-30 8:53 ` Paolo Bonzini
2016-10-31 1:40 ` Jike Song [this message]
2016-10-29 20:05 ` [v2 4/5] vfio: implement APIs to set/put kvm to/from vfio group Jike Song
2016-10-29 22:15 ` kbuild test robot
2016-10-30 8:52 ` Paolo Bonzini
2016-10-31 2:12 ` Jike Song
2016-10-29 20:05 ` [v2 5/5] KVM: set/clear kvm to/from vfio group during add/delete Jike Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5816A10A.7010203@intel.com \
--to=jike.song@intel.com \
--cc=alex.williamson@redhat.com \
--cc=cjia@nvidia.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.