From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1c1OYo-0002vB-9z
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 22:12:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1c1OYl-0007bh-4X
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 22:12:22 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:61901)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1c1OYk-0007ag-Kk
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 22:12:19 -0400
References: <1477824430-1460-1-git-send-email-amit.shah@redhat.com>
	<1477824430-1460-11-git-send-email-amit.shah@redhat.com>
	<87r36wbfpt.fsf@emacs.mitica>
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Message-ID: <5817F99B.1050501@huawei.com>
Date: Tue, 1 Nov 2016 10:10:35 +0800
MIME-Version: 1.0
In-Reply-To: <87r36wbfpt.fsf@emacs.mitica>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 10/18] COLO: Add checkpoint-delay parameter
 for migrate-set-parameters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com, Amit Shah <amit.shah@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu list <qemu-devel@nongnu.org>

On 2016/11/1 1:17, Juan Quintela wrote:
> Amit Shah <amit.shah@redhat.com> wrote:
>> From: zhanghailiang <zhang.zhanghailiang@huawei.com>
>>
>> Add checkpoint-delay parameter for migrate-set-parameters, so that
>> we can control the checkpoint frequency when COLO is in periodic mode.
>>
>>
>> @@ -587,6 +593,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)
>>       params->max_bandwidth = s->parameters.max_bandwidth;
>>       params->has_downtime_limit = true;
>>       params->downtime_limit = s->parameters.downtime_limit;
>> +    params->x_checkpoint_delay = s->parameters.x_checkpoint_delay;
>>
>>       return params;
>>   }
>
> I think you are missing here:
>
> params->has_x_checkpoint_delay = true;
>

Good catch, this will influence output of
qmp command 'query-migrate-parameters'.
(Without this, 'query-migrate-parameters'
command will shows no "x-checkpoint-delay": 200)

I will send a patch to fix it, thanks very much.

Hailiang

> No?
>
> Later, Juan
>
> .
>