From: Timur Tabi <timur@codeaurora.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] [RFC] net: phy: phy drivers should not set SUPPORTED_Pause or SUPPORTED_Asym_Pause
Date: Tue, 1 Nov 2016 13:45:04 -0500 [thread overview]
Message-ID: <5818E2B0.80902@codeaurora.org> (raw)
In-Reply-To: <aa0224f1-814a-d281-ad26-6c8086e40658@gmail.com>
Florian Fainelli wrote:
> So in premise, this is good, and is exactly what I have in mind for the
> series that I am cooking, but if we apply this alone, without a change
> in drivers/net/phy/phy.c which adds SUPPORTED_Pause |
> SUPPORTED_AsymPause to phydev->features, we are basically breaking the
> Ethernet MAC drivers that don't explicitly override phydev->features and
> yet rely on that to get flow control to work.
That's what I figured, but I wasn't sure how to handle that. However,
isn't the ability to pass pause frames a feature that some PHYs do not
have? That is, does every PHY support bits 10 and 11 in register 4?
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-11-01 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 17:18 [PATCH] [RFC] net: phy: phy drivers should not set SUPPORTED_Pause or SUPPORTED_Asym_Pause Timur Tabi
2016-11-01 18:35 ` Florian Fainelli
2016-11-01 18:45 ` Timur Tabi [this message]
2016-11-01 19:03 ` Florian Fainelli
2016-11-01 19:19 ` Timur Tabi
2016-11-07 16:30 ` Timur Tabi
2016-11-08 20:43 ` Timur Tabi
2016-11-09 17:06 ` Florian Fainelli
2016-11-09 17:34 ` Timur Tabi
2016-11-09 17:55 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5818E2B0.80902@codeaurora.org \
--to=timur@codeaurora.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.