From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1c1pxe-0003VB-60 for mharc-qemu-trivial@gnu.org; Wed, 02 Nov 2016 03:27:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1pxb-0003Sk-Cl for qemu-trivial@nongnu.org; Wed, 02 Nov 2016 03:27:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1pxY-0007wV-8b for qemu-trivial@nongnu.org; Wed, 02 Nov 2016 03:27:47 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:40422) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1pxX-0007uZ-K8; Wed, 02 Nov 2016 03:27:44 -0400 Received: from 172.24.1.136 (EHLO szxeml434-hub.china.huawei.com) ([172.24.1.136]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DUL23535; Wed, 02 Nov 2016 15:27:10 +0800 (CST) Received: from [127.0.0.1] (10.177.24.212) by szxeml434-hub.china.huawei.com (10.82.67.225) with Microsoft SMTP Server id 14.3.235.1; Wed, 2 Nov 2016 15:26:59 +0800 To: Eric Blake , , References: <1477979405-16264-1-git-send-email-zhang.zhanghailiang@huawei.com> <142defcb-88bd-727f-70e4-0c8ace3f2e76@redhat.com> CC: , , From: Hailiang Zhang Message-ID: <58199541.2040909@huawei.com> Date: Wed, 2 Nov 2016 15:26:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <142defcb-88bd-727f-70e4-0c8ace3f2e76@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.24.212] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 58.251.152.64 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: fix missing assignment for has_x_checkpoint_delay X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 07:27:48 -0000 On 2016/11/1 22:27, Eric Blake wrote: > On 11/01/2016 12:50 AM, zhanghailiang wrote: >> We forgot to assign true to params->has_x_checkpoint_delay parameter >> in qmp_query_migrate_parameters. >> >> Without this, qmp command 'query-migrate-parameters' doesn't show the >> default value for x-checkpoint-delay option. >> It doesn't influence output of hmp command 'info migrate_parameters'. > > Well, only because the current code doesn't forcefully assign missing > optional parameters to any other value. But HMP was relying on > unspecified behavior, that could have broken with any other qapi change. > > I might word the commit message: > > This also fixes the fact that HMP was relying on unspecified behavior by > reading x_checkpoint_delay without checking has_x_checkpoint_delay. > > Up to the maintainer, though, since the patch itself is fine. > OK, thanks, I'd like to fix the message as your said :) >> >> Signed-off-by: zhanghailiang >> --- >> hmp.c | 1 + >> migration/migration.c | 1 + >> 2 files changed, 2 insertions(+) > > Reviewed-by: Eric Blake > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1pxd-0003UY-DG for qemu-devel@nongnu.org; Wed, 02 Nov 2016 03:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1pxc-0007xC-GI for qemu-devel@nongnu.org; Wed, 02 Nov 2016 03:27:49 -0400 References: <1477979405-16264-1-git-send-email-zhang.zhanghailiang@huawei.com> <142defcb-88bd-727f-70e4-0c8ace3f2e76@redhat.com> From: Hailiang Zhang Message-ID: <58199541.2040909@huawei.com> Date: Wed, 2 Nov 2016 15:26:57 +0800 MIME-Version: 1.0 In-Reply-To: <142defcb-88bd-727f-70e4-0c8ace3f2e76@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: fix missing assignment for has_x_checkpoint_delay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , quintela@redhat.com, amit.shah@redhat.com Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, dgilbert@redhat.com On 2016/11/1 22:27, Eric Blake wrote: > On 11/01/2016 12:50 AM, zhanghailiang wrote: >> We forgot to assign true to params->has_x_checkpoint_delay parameter >> in qmp_query_migrate_parameters. >> >> Without this, qmp command 'query-migrate-parameters' doesn't show the >> default value for x-checkpoint-delay option. >> It doesn't influence output of hmp command 'info migrate_parameters'. > > Well, only because the current code doesn't forcefully assign missing > optional parameters to any other value. But HMP was relying on > unspecified behavior, that could have broken with any other qapi change. > > I might word the commit message: > > This also fixes the fact that HMP was relying on unspecified behavior by > reading x_checkpoint_delay without checking has_x_checkpoint_delay. > > Up to the maintainer, though, since the patch itself is fine. > OK, thanks, I'd like to fix the message as your said :) >> >> Signed-off-by: zhanghailiang >> --- >> hmp.c | 1 + >> migration/migration.c | 1 + >> 2 files changed, 2 insertions(+) > > Reviewed-by: Eric Blake >